Moved asset check to top of _checkBalance

naddison36 · naddison36 · commit 19c20e61b455 · 2024-08-02T16:30:28.000+10:00
diff --git a/contracts/contracts/vault/OETHVaultCore.sol b/contracts/contracts/vault/OETHVaultCore.sol
@@ -397,12 +397,12 @@ contract OETHVaultCore is VaultCore {
         override
         returns (uint256 balance)
     {
-        balance = super._checkBalance(_asset);
-
         if (_asset != weth) {
             return 0;
         }
 
+        balance = super._checkBalance(_asset);
+
         WithdrawalQueueMetadata memory queue = withdrawalQueueMetadata;
         // If there is not enough WETH in the vault and strategies to cover the outstanding withdrawals.
         // It can happen if more than half of the users have requested a withdrawal but have not claimed.

Original file line number	Diff line number	Diff line change
`@@ -397,12 +397,12 @@ contract OETHVaultCore is VaultCore {`
`397`	`397`	`override`
`398`	`398`	`returns (uint256 balance)`
`399`	`399`	`{`
`400`		`- balance = super._checkBalance(_asset);`
`401`		`-`
`402`	`400`	`if (_asset != weth) {`
`403`	`401`	`return 0;`
`404`	`402`	`}`
`405`	`403`
	`404`	`+ balance = super._checkBalance(_asset);`
	`405`	`+`
`406`	`406`	`WithdrawalQueueMetadata memory queue = withdrawalQueueMetadata;`
`407`	`407`	`// If there is not enough WETH in the vault and strategies to cover the outstanding withdrawals.`
`408`	`408`	`// It can happen if more than half of the users have requested a withdrawal but have not claimed.`