From 086186760c4288fce2914ac7bb9c11efd89f2aaf Mon Sep 17 00:00:00 2001 From: Claudio Viquez Date: Mon, 13 Aug 2018 09:08:29 -0600 Subject: [PATCH 1/2] Added Event tests to Pausable contract --- test/lifecycle/Pausable.test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/lifecycle/Pausable.test.js b/test/lifecycle/Pausable.test.js index 4ff085997c6..238787056b2 100644 --- a/test/lifecycle/Pausable.test.js +++ b/test/lifecycle/Pausable.test.js @@ -64,4 +64,12 @@ contract('Pausable', function () { const drasticMeasureTaken = await this.Pausable.drasticMeasureTaken(); drasticMeasureTaken.should.be.false; }); + + it('should log events appropriately', async function () { + const setPauseLogs = (await this.Pausable.pause()).logs; + setPauseLogs.find(e => e.event === 'Pause'); + + const setUnPauseLogs = (await this.Pausable.unpause()).logs; + setUnPauseLogs.find(e => e.event === 'UnPause'); + }); }); From 11890df50d7617e63c7ef3af429a331e2cd1a012 Mon Sep 17 00:00:00 2001 From: Claudio Viquez Date: Mon, 13 Aug 2018 13:29:56 -0600 Subject: [PATCH 2/2] Applied PR comments --- test/lifecycle/Pausable.test.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/lifecycle/Pausable.test.js b/test/lifecycle/Pausable.test.js index 238787056b2..3fa6f287042 100644 --- a/test/lifecycle/Pausable.test.js +++ b/test/lifecycle/Pausable.test.js @@ -1,4 +1,5 @@ const { assertRevert } = require('../helpers/assertRevert'); +const expectEvent = require('../helpers/expectEvent'); const PausableMock = artifacts.require('PausableMock'); const BigNumber = web3.BigNumber; @@ -65,11 +66,11 @@ contract('Pausable', function () { drasticMeasureTaken.should.be.false; }); - it('should log events appropriately', async function () { + it('should log Pause and Unpause events appropriately', async function () { const setPauseLogs = (await this.Pausable.pause()).logs; - setPauseLogs.find(e => e.event === 'Pause'); + expectEvent.inLogs(setPauseLogs, 'Pause'); const setUnPauseLogs = (await this.Pausable.unpause()).logs; - setUnPauseLogs.find(e => e.event === 'UnPause'); + expectEvent.inLogs(setUnPauseLogs, 'Unpause'); }); });