-
Notifications
You must be signed in to change notification settings - Fork 64
ModelicaSystemCMD - use OMCPath #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adeas31
merged 12 commits into
OpenModelica:master
from
syntron:ModelicaSystemCmd_use_OMCPath
Nov 5, 2025
Merged
ModelicaSystemCMD - use OMCPath #324
adeas31
merged 12 commits into
OpenModelica:master
from
syntron:ModelicaSystemCmd_use_OMCPath
Nov 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Sonyoyo feel free to also test this PR - it should allow you to use ModelicaSystem in combination with OMC in WSL Test case to check: Please keep in mind that Python >= 3.12 is needed! |
80f5c96 to
f469523
Compare
f469523 to
62cb4d3
Compare
62cb4d3 to
2616a18
Compare
890401c to
eea4a5d
Compare
858b873 to
1104c06
Compare
1104c06 to
297d2f5
Compare
297d2f5 to
be777df
Compare
Member
|
Please rebase again. |
…te() * no dependency loop OMCsessionZMQ => OMCProcess* => OMCSessionZMQ * check if model executable exists will be handled via ModelicaSystemCmd
be777df to
14629eb
Compare
Contributor
Author
|
Rebased; see issue #361 |
adeas31
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OMCPath in ModelicaSystemCMD - this allows to run ModelicaSystem simulations using docker or WSL
Please check
tests.test_ModelicaSystem.test_getSolutions_dockerfor an exampleBased on PR #322
Additional requirements: PR #331 and PR #332