[ModelicaSystem.getSolution()] do not try to continue on error but fail

Rule: fail early, fail hard - tell the user that something is wrong!

In this case, the user ask for the solution but could get None (= plain
'return') - this would case hard to track errors later (if verbose==False
and raiseerrors==False)

Author: syntron

OMPython/ModelicaSystem.py

@@ -674,29 +674,24 @@ def getSolutions(self, varList=None, resultfile=None):  # 12
 
         # check for result file exits
         if not os.path.exists(resFile):
-            errstr = f"Error: Result file does not exist {resFile}"
-            self._raise_error(errstr=errstr)
-            return
+            raise ModelicaSystemError(f"Result file does not exist {resFile}")
         resultVars = self.sendExpression(f'readSimulationResultVars("{resFile}")')
         self.sendExpression("closeSimulationResultFile()")
         if varList is None:
             return resultVars
         elif isinstance(varList, str):
             if varList not in resultVars and varList != "time":
-                self._raise_error(errstr=f'!!! {varList} does not exist')
-                return
+                raise ModelicaSystemError(f"Requested data {repr(varList)} does not exist")
             res = self.sendExpression(f'readSimulationResult("{resFile}", {{{varList}}})')
             npRes = np.array(res)
             self.sendExpression("closeSimulationResultFile()")
             return npRes
         elif isinstance(varList, list):
-            # varList, = varList
-            for v in varList:
-                if v == "time":
+            for var in varList:
+                if var == "time":
                     continue
-                if v not in resultVars:
-                    self._raise_error(errstr=f'!!! {v} does not exist')
-                    return
+                if var not in resultVars:
+                    raise ModelicaSystemError(f"Requested data {repr(var)} does not exist")
             variables = ",".join(varList)
             res = self.sendExpression(f'readSimulationResult("{resFile}",{{{variables}}})')
             npRes = np.array(res)
@@ -737,7 +732,8 @@ def apply_single(args1):
                 return True
 
             else:
-                self._raise_error(errstr=f'"{value[0]}" is not a {args3} variable')
+                raise ModelicaSystemError("Unhandled case in setMethodHelper.apply_single() - "
+                                          f"{repr(value[0])} is not a {repr(args3)} variable")
 
         result = []
         if isinstance(args1, str):