From c16b5be6345b3e9a6d50afabdea8bb1109f7bf64 Mon Sep 17 00:00:00 2001 From: spinsch Date: Thu, 13 Sep 2018 18:42:16 +0200 Subject: [PATCH] Reduce unnecessary History updates on order saving. if store-id stored into model data array, the whole history collection of an order will get updated. to reduce unnecessary mysql updates, i've used the store id directly from the order object. fyi: all changes into a model data array will set a flag (save me again). --- .../core/Mage/Sales/Model/Order/Status/History.php | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/app/code/core/Mage/Sales/Model/Order/Status/History.php b/app/code/core/Mage/Sales/Model/Order/Status/History.php index cbba96b085c..289a306478a 100644 --- a/app/code/core/Mage/Sales/Model/Order/Status/History.php +++ b/app/code/core/Mage/Sales/Model/Order/Status/History.php @@ -75,7 +75,7 @@ protected function _construct() } /** - * Set order object and grab some metadata from it + * Set order object * * @param Mage_Sales_Model_Order $order * @return Mage_Sales_Model_Order_Status_History @@ -83,7 +83,6 @@ protected function _construct() public function setOrder(Mage_Sales_Model_Order $order) { $this->_order = $order; - $this->setStoreId($order->getStoreId()); return $this; } @@ -147,6 +146,16 @@ public function getStore() return Mage::app()->getStore(); } + /** + * Get store id + * + * @return integer + */ + public function getStoreId() + { + return $this->getStore()->getStoreId(); + } + /** * Set order again if required *