From f42d31e6378c7cc657ee1a6c63158d5499114fc7 Mon Sep 17 00:00:00 2001 From: Justin Beaty Date: Sun, 14 Aug 2022 16:14:25 -0700 Subject: [PATCH 1/9] Remove toggleSelectsUnderBlock & setLoaderPosition --- .../template/notification/window.phtml | 2 - js/mage/adminhtml/giftmessage.js | 2 - js/mage/adminhtml/loader.js | 53 ++----------------- .../adminhtml/product/composite/configure.js | 23 -------- 4 files changed, 4 insertions(+), 76 deletions(-) diff --git a/app/design/adminhtml/default/default/template/notification/window.phtml b/app/design/adminhtml/default/default/template/notification/window.phtml index 57d3d386840..764a1228b12 100644 --- a/app/design/adminhtml/default/default/template/notification/window.phtml +++ b/app/design/adminhtml/default/default/template/notification/window.phtml @@ -30,13 +30,11 @@ function openMessagePopup() { var height = $('html-body').getHeight(); $('message-popup-window-mask').setStyle({'height':height+'px'}); - toggleSelectsUnderBlock($('message-popup-window-mask'), false); Element.show('message-popup-window-mask'); $('message-popup-window').addClassName('show'); } function closeMessagePopup() { - toggleSelectsUnderBlock($('message-popup-window-mask'), true); Element.hide('message-popup-window-mask'); $('message-popup-window').removeClassName('show'); messagePopupClosed = true; diff --git a/js/mage/adminhtml/giftmessage.js b/js/mage/adminhtml/giftmessage.js index a0739019459..a79f6419de1 100644 --- a/js/mage/adminhtml/giftmessage.js +++ b/js/mage/adminhtml/giftmessage.js @@ -166,7 +166,6 @@ GiftOptionsPopup.prototype = { var element = Event.element(event).id; var itemId = element.sub('gift_options_link_',''); - toggleSelectsUnderBlock(this.giftOptionsWindowMask, false); this.giftOptionsWindowMask = $('gift_options_window_mask'); this.giftOptionsWindow = $('gift_options_configure'); this.giftOptionsWindow.select('select').each(function(el){ @@ -207,7 +206,6 @@ GiftOptionsPopup.prototype = { }, closeWindow : function() { - toggleSelectsUnderBlock(this.giftOptionsWindowMask, true); this.giftOptionsWindowMask.style.display = 'none'; this.giftOptionsWindow.style.display = 'none'; } diff --git a/js/mage/adminhtml/loader.js b/js/mage/adminhtml/loader.js index a01eba1c427..785d645bc74 100644 --- a/js/mage/adminhtml/loader.js +++ b/js/mage/adminhtml/loader.js @@ -207,17 +207,14 @@ function showLoader(loaderArea) { return; } Element.clonePosition(loadingMask, loaderArea, {offsetLeft:-2}); - toggleSelectsUnderBlock(loadingMask, false); Element.show(loadingMask); Element.childElements(loadingMask).invoke('hide'); - setLoaderPosition(); loaderTimeout = setTimeout(function() { Element.childElements(loadingMask).invoke('show'); }, typeof window.LOADING_TIMEOUT === 'undefined' ? 200 : window.LOADING_TIMEOUT); } function hideLoader() { - toggleSelectsUnderBlock($('loading-mask'), true); Element.hide('loading-mask'); if(loaderTimeout) { clearTimeout(loaderTimeout); @@ -225,54 +222,12 @@ function hideLoader() { } } -/** - * @todo need calculate middle of visible area and scroll bind - */ -function setLoaderPosition(){ - var elem = $('loading_mask_loader'); - if (elem && Prototype.Browser.IE) { - var elementDims = elem.getDimensions(); - var viewPort = document.viewport.getDimensions(); - var offsets = document.viewport.getScrollOffsets(); - elem.style.left = Math.floor(viewPort.width / 2 + offsets.left - elementDims.width / 2) + 'px'; - elem.style.top = Math.floor(viewPort.height / 2 + offsets.top - elementDims.height / 2) + 'px'; - elem.style.position = 'absolute'; - } +// Deprecated since 20.0.17 +function setLoaderPosition() { } -/*function getRealHeight() { - var body = document.body; - if (window.innerHeight && window.scrollMaxY) { - return window.innerHeight + window.scrollMaxY; - } - return Math.max(body.scrollHeight, body.offsetHeight); -}*/ - - - -function toggleSelectsUnderBlock(block, flag){ - if(Prototype.Browser.IE){ - var selects = document.getElementsByTagName("select"); - for(var i=0; i Date: Sun, 14 Aug 2022 16:17:02 -0700 Subject: [PATCH 2/9] Remove Prototype.Browser.IE --- .../default/template/catalog/product/edit.phtml | 4 +--- .../catalog/product/edit/action/attribute.phtml | 4 +--- js/mage/adminhtml/sales.js | 14 +------------- js/mage/adminhtml/wysiwyg/tiny_mce/setup.js | 8 -------- js/mage/translate_inline.js | 14 -------------- 5 files changed, 3 insertions(+), 41 deletions(-) diff --git a/app/design/adminhtml/default/default/template/catalog/product/edit.phtml b/app/design/adminhtml/default/default/template/catalog/product/edit.phtml index 14cfff9855e..2a8b64c274e 100644 --- a/app/design/adminhtml/default/default/template/catalog/product/edit.phtml +++ b/app/design/adminhtml/default/default/template/catalog/product/edit.phtml @@ -56,9 +56,7 @@ if (response.attribute && $(response.attribute)) { $(response.attribute).setHasError(true, productForm); Validation.ajaxError($(response.attribute), response.message); - if (!Prototype.Browser.IE){ - $(response.attribute).focus(); - } + $(response.attribute).focus(); } else if ($('messages')) { $('messages').innerHTML = ''; diff --git a/app/design/adminhtml/default/default/template/catalog/product/edit/action/attribute.phtml b/app/design/adminhtml/default/default/template/catalog/product/edit/action/attribute.phtml index 57ed65d4d56..789b47eb880 100644 --- a/app/design/adminhtml/default/default/template/catalog/product/edit/action/attribute.phtml +++ b/app/design/adminhtml/default/default/template/catalog/product/edit/action/attribute.phtml @@ -42,9 +42,7 @@ attributesForm._processValidationResult = function(transport) { if (response.attribute && $(response.attribute)) { $(response.attribute).setHasError(true, attributesForm); Validation.ajaxError($(response.attribute), response.message); - if (!Prototype.Browser.IE){ - $(response.attribute).focus(); - } + $(response.attribute).focus(); } else if ($('messages')) { $('messages').innerHTML = ''; } diff --git a/js/mage/adminhtml/sales.js b/js/mage/adminhtml/sales.js index 8527b537ef0..7d6148cdc1a 100644 --- a/js/mage/adminhtml/sales.js +++ b/js/mage/adminhtml/sales.js @@ -984,7 +984,7 @@ AdminOrder.prototype = { if ('message' != id || response[id]) { var wrapper = new Element('div'); wrapper.update(response[id] ? response[id] : ''); - $(this.getAreaId(id)).update(Prototype.Browser.IE ? wrapper.outerHTML : wrapper); + $(this.getAreaId(id)).update(wrapper); } if ($(this.getAreaId(id)).callback) { this[$(this.getAreaId(id)).callback](); @@ -1137,18 +1137,6 @@ AdminOrder.prototype = { parentEl.addClassName('ignore-validate'); } - if (Prototype.Browser.IE) { - parentEl.select('select').each(function (elem) { - if (show) { - elem.needShowOnSuccess = false; - elem.style.visibility = ''; - } else { - elem.style.visibility = 'hidden'; - elem.needShowOnSuccess = true; - } - }); - } - parentEl.setStyle({position: 'relative'}); el.setStyle({ display: show ? 'none' : '', diff --git a/js/mage/adminhtml/wysiwyg/tiny_mce/setup.js b/js/mage/adminhtml/wysiwyg/tiny_mce/setup.js index 0c17bcb609d..eccde86fc56 100644 --- a/js/mage/adminhtml/wysiwyg/tiny_mce/setup.js +++ b/js/mage/adminhtml/wysiwyg/tiny_mce/setup.js @@ -478,14 +478,6 @@ tinyMceWysiwygSetup.prototype = this.getPluginButtons().each(function(e) { e.show(); }); - if (Prototype.Browser.IE) { - // workaround for IE textarea redraw bug - window.setTimeout(function() { - if ($(this.id)) { - $(this.id).value = $(this.id).value; - } - }.bind(this), 0); - } }, closePopups: function() { diff --git a/js/mage/translate_inline.js b/js/mage/translate_inline.js index e88f0c7bd28..c113dc8adba 100644 --- a/js/mage/translate_inline.js +++ b/js/mage/translate_inline.js @@ -25,20 +25,6 @@ TranslateInline.prototype = { this.trigTimer = null; this.trigContentEl = null; - if (Prototype.Browser.IE) { - $$('*[data-translate]').each(this.initializeElement.bind(this)); - var scope = this; - Ajax.Responders.register({ onComplete: function() { - window.setTimeout(scope.reinitElements.bind(scope), 50); - } - }); - var ElementNode = (typeof HTMLElement != 'undefined' ? HTMLElement : Element); - var ElementUpdate = ElementNode.prototype.update; - ElementNode.prototype.update = function() { - ElementUpdate.apply(this, arguments); - $(this).select('*[data-translate]').each(scope.initializeElement.bind(scope)); - }; - } this.trigEl = $(trigEl); this.trigEl.observe('click', this.formShow.bind(this)); From a53d624062ad607ad6e9adc823472417faf8b75b Mon Sep 17 00:00:00 2001 From: Justin Beaty Date: Sun, 14 Aug 2022 16:31:37 -0700 Subject: [PATCH 3/9] more MSIE removal --- js/mage/adminhtml/tools.js | 15 +-------------- js/varien/js.js | 3 --- js/varien/menu.js | 17 ----------------- js/varien/product.js | 6 ------ 4 files changed, 1 insertion(+), 40 deletions(-) diff --git a/js/mage/adminhtml/tools.js b/js/mage/adminhtml/tools.js index ee53c8b258a..480facbc8a0 100644 --- a/js/mage/adminhtml/tools.js +++ b/js/mage/adminhtml/tools.js @@ -257,7 +257,6 @@ var toolbarToggle = { headerOffset: null, // Normal toolbar offset - calculated once headerCopy: null, // Floating toolbar eventsAdded: false, // We're listening to scroll/resize - compatible: !navigator.appVersion.match('MSIE 6.'), // Whether object is compatible with browser (do not support old browsers, legacy code) // Inits object and pushes it into work. Can be used to init/reset(update) object by current DOM. reset: function () { @@ -271,10 +270,6 @@ var toolbarToggle = { // Creates toolbar and inits all needed properties createToolbar: function () { - if (!this.compatible) { - return; - } - // Extract header that we will use as toolbar var headers = $$('.content-header'); for (var i = headers.length - 1; i >= 0; i--) { @@ -318,7 +313,7 @@ var toolbarToggle = { // Checks whether object properties are ready and valid ready: function () { // Return definitely boolean value - return (this.compatible && this.header && this.headerCopy && this.headerCopy.parentNode) ? true : false; + return (this.header && this.headerCopy && this.headerCopy.parentNode) ? true : false; }, // Updates toolbars for current scroll - shows/hides normal and floating toolbar @@ -409,10 +404,6 @@ var toolbarToggle = { // Starts object on window load startOnLoad: function () { - if (!this.compatible) { - return; - } - if (!this.funcOnWindowLoad) { this.funcOnWindowLoad = this.start.bind(this); } @@ -429,10 +420,6 @@ var toolbarToggle = { // Starts object by creating toolbar and enabling scroll/resize events start: function () { - if (!this.compatible) { - return; - } - this.reset(); this.startListening(); }, diff --git a/js/varien/js.js b/js/varien/js.js index 5f131627a2b..2d2ce684cc5 100644 --- a/js/varien/js.js +++ b/js/varien/js.js @@ -239,9 +239,6 @@ function expandDetails(el, childClass) { } } -// Version 1.0 -var isIE = navigator.appVersion.match(/MSIE/) == "MSIE"; - if (!window.Varien) var Varien = new Object(); diff --git a/js/varien/menu.js b/js/varien/menu.js index 43d6847960f..ac1f40ae36d 100644 --- a/js/varien/menu.js +++ b/js/varien/menu.js @@ -30,21 +30,13 @@ var mainNav = function() { settings : { show_delay : 0, hide_delay : 0, - _ie6 : /MSIE 6.+Win/.test(navigator.userAgent), - _ie7 : /MSIE 7.+Win/.test(navigator.userAgent) }, init : function(obj, level) { obj.lists = obj.childElements(); obj.lists.each(function(el,ind){ main.handlNavElement(el); - if((main.settings._ie6 || main.settings._ie7) && level){ - main.ieFixZIndex(el, ind, obj.lists.size()); - } }); - if(main.settings._ie6 && !level){ - document.execCommand("BackgroundImageCache", false, true); - } }, handlNavElement : function(list) { @@ -61,15 +53,6 @@ var mainNav = function() { } }, - ieFixZIndex : function(el, i, l) { - if(el.tagName.toString().toLowerCase().indexOf("iframe") == -1){ - el.style.zIndex = l - i; - } else { - el.onmouseover = "null"; - el.onmouseout = "null"; - } - }, - fireNavEvent : function(elm,ev) { if(ev){ elm.addClassName("over"); diff --git a/js/varien/product.js b/js/varien/product.js index 7cba1649334..183a25b2873 100644 --- a/js/varien/product.js +++ b/js/varien/product.js @@ -103,12 +103,6 @@ Product.Zoom.prototype = { toggleFull: function () { this.showFull = !this.showFull; - //Hide selects for IE6 only - if (typeof document.body.style.maxHeight == "undefined") { - for (i=0; i Date: Sun, 14 Aug 2022 16:43:15 -0700 Subject: [PATCH 4/9] remove IE hack in grids --- js/mage/adminhtml/grid.js | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/js/mage/adminhtml/grid.js b/js/mage/adminhtml/grid.js index f285e3a8323..2928c955778 100644 --- a/js/mage/adminhtml/grid.js +++ b/js/mage/adminhtml/grid.js @@ -180,27 +180,10 @@ varienGrid.prototype = { setLocation(response.ajaxRedirect); } } else { - /** - * For IE <= 7. - * If there are two elements, and first has name, that equals id of second. - * In this case, IE will choose one that is above - * - * @see https://prototype.lighthouseapp.com/projects/8886/tickets/994-id-selector-finds-elements-by-name-attribute-in-ie7 - */ - var divId = $(this.containerId); - if (divId.id == this.containerId) { - divId.update(responseText); - } else { - $$('div[id="'+this.containerId+'"]')[0].update(responseText); - } + $(this.containerId).update(responseText); } } catch (e) { - var divId = $(this.containerId); - if (divId.id == this.containerId) { - divId.update(responseText); - } else { - $$('div[id="'+this.containerId+'"]')[0].update(responseText); - } + $(this.containerId).update(responseText); } }.bind(this) }); From 0c95f1ca0cd081c63578a750bca24396ec19e482 Mon Sep 17 00:00:00 2001 From: Justin Beaty Date: Sun, 14 Aug 2022 16:53:00 -0700 Subject: [PATCH 5/9] more MSIE removal --- js/mage/adminhtml/browser.js | 2 -- js/mage/adminhtml/form.js | 20 ------------- .../themes/advanced/skins/default/content.css | 12 -------- js/mage/adminhtml/wysiwyg/widget.js | 2 -- js/mage/directpost.js | 16 +++-------- js/varien/js.js | 28 ++----------------- 6 files changed, 7 insertions(+), 73 deletions(-) diff --git a/js/mage/adminhtml/browser.js b/js/mage/adminhtml/browser.js index c6bbddcd4ba..d1dc0478357 100644 --- a/js/mage/adminhtml/browser.js +++ b/js/mage/adminhtml/browser.js @@ -46,8 +46,6 @@ MediabrowserUtility = { window = this.dialogWindow; } if (window) { - // IE fix - hidden form select fields after closing dialog - WindowUtilities._showSelect(); window.close(); } } diff --git a/js/mage/adminhtml/form.js b/js/mage/adminhtml/form.js index 03f077b327f..dcb143a5568 100644 --- a/js/mage/adminhtml/form.js +++ b/js/mage/adminhtml/form.js @@ -386,26 +386,6 @@ RegionUpdater.prototype = { regionUpdater = RegionUpdater; -/** - * Fix errorrs in IE - */ -Event.pointerX = function(event){ - try{ - return event.pageX || (event.clientX +(document.documentElement.scrollLeft || document.body.scrollLeft)); - } - catch(e){ - - } -}; -Event.pointerY = function(event){ - try{ - return event.pageY || (event.clientY +(document.documentElement.scrollTop || document.body.scrollTop)); - } - catch(e){ - - } -}; - SelectUpdater = Class.create(); SelectUpdater.prototype = { initialize: function (firstSelect, secondSelect, selectFirstMessage, noValuesMessage, values, selected) diff --git a/js/mage/adminhtml/wysiwyg/tiny_mce/themes/advanced/skins/default/content.css b/js/mage/adminhtml/wysiwyg/tiny_mce/themes/advanced/skins/default/content.css index 6bfab5aeaa5..80bf9943ba1 100644 --- a/js/mage/adminhtml/wysiwyg/tiny_mce/themes/advanced/skins/default/content.css +++ b/js/mage/adminhtml/wysiwyg/tiny_mce/themes/advanced/skins/default/content.css @@ -35,15 +35,3 @@ del {color:red; text-decoration:line-through} cite {border-bottom:1px dashed blue} acronym {border-bottom:1px dotted #CCC; cursor:help} abbr, html\:abbr {border-bottom:1px dashed #CCC; cursor:help} - -/* IE */ -* html body { -scrollbar-3dlight-color:#F0F0EE; -scrollbar-arrow-color:#676662; -scrollbar-base-color:#F0F0EE; -scrollbar-darkshadow-color:#DDD; -scrollbar-face-color:#E0E0DD; -scrollbar-highlight-color:#F0F0EE; -scrollbar-shadow-color:#F0F0EE; -scrollbar-track-color:#F5F5F5; -} diff --git a/js/mage/adminhtml/wysiwyg/widget.js b/js/mage/adminhtml/wysiwyg/widget.js index 9edacbeca02..b23a938530c 100644 --- a/js/mage/adminhtml/wysiwyg/widget.js +++ b/js/mage/adminhtml/wysiwyg/widget.js @@ -63,8 +63,6 @@ var widgetTools = { window = this.dialogWindow; } if (window) { - // IE fix - hidden form select fields after closing dialog - WindowUtilities._showSelect(); window.close(); } } diff --git a/js/mage/directpost.js b/js/mage/directpost.js index 9a37241c168..b7f8045c893 100644 --- a/js/mage/directpost.js +++ b/js/mage/directpost.js @@ -365,18 +365,10 @@ directPost.prototype = { createHiddenElement : function(name, value) { var field; - if (isIE) { - field = document.createElement('input'); - field.setAttribute('type', 'hidden'); - field.setAttribute('name', name); - field.setAttribute('value', value); - } else { - field = document.createElement('input'); - field.type = 'hidden'; - field.name = name; - field.value = value; - } - + field = document.createElement('input'); + field.type = 'hidden'; + field.name = name; + field.value = value; return field; }, diff --git a/js/varien/js.js b/js/varien/js.js index 2d2ce684cc5..db6cfdf6799 100644 --- a/js/varien/js.js +++ b/js/varien/js.js @@ -614,16 +614,9 @@ Element.addMethods({ * @example fireEvent($('my-input', 'click')); */ function fireEvent(element, event) { - if (document.createEvent) { - // dispatch for all browsers except IE before version 9 - var evt = document.createEvent("HTMLEvents"); - evt.initEvent(event, true, true ); // event type, bubbling, cancelable - return element.dispatchEvent(evt); - } else { - // dispatch for IE before version 9 - var evt = document.createEventObject(); - return element.fireEvent('on' + event, evt); - } + var evt = document.createEvent("HTMLEvents"); + evt.initEvent(event, true, true ); // event type, bubbling, cancelable + return element.dispatchEvent(evt); } /** @@ -647,21 +640,6 @@ function modulo(dividend, divisor) return remainder; } -/** - * createContextualFragment is not supported in IE9. Adding its support. - */ -if ((typeof Range != "undefined") && !Range.prototype.createContextualFragment) -{ - Range.prototype.createContextualFragment = function(html) - { - var frag = document.createDocumentFragment(), - div = document.createElement("div"); - frag.appendChild(div); - div.outerHTML = html; - return frag; - }; -} - /** * Create form element. Set parameters into it and send * From e9226d26868e841f2c86d0d2b53c1b06ef05e86f Mon Sep 17 00:00:00 2001 From: Justin Beaty Date: Sun, 14 Aug 2022 16:56:09 -0700 Subject: [PATCH 6/9] IE8 styles --- skin/adminhtml/default/default/boxes.css | 2 +- skin/frontend/rwd/default/css/styles.css | 3 --- skin/frontend/rwd/default/scss/core/_form.scss | 4 ---- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/skin/adminhtml/default/default/boxes.css b/skin/adminhtml/default/default/boxes.css index e36d20e50e3..36cc247856b 100644 --- a/skin/adminhtml/default/default/boxes.css +++ b/skin/adminhtml/default/default/boxes.css @@ -653,7 +653,7 @@ div.autocomplete ul li { padding:.5em .7em; min-height:32px; cursor:pointer; tex .left-col-block { width:200px; } /* Floating Content Header */ /* Used to make action buttons always within reach */ -.content-header-floating { display:none; position:fixed; left:0; top:0; width:100%; border-bottom:solid 1px #988753; z-index:100; background:#fdfaa4; -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=85)"/* IE8 */; opacity:.85; } +.content-header-floating { display:none; position:fixed; left:0; top:0; width:100%; border-bottom:solid 1px #988753; z-index:100; background:#fdfaa4; opacity:.85; } .content-header-floating .content-header { padding:6px 8px 4px 8px; margin-bottom:0; border:0; } .content-header-floating td { padding-right:20px; } .content-header-floating button { margin-top:3px; } diff --git a/skin/frontend/rwd/default/css/styles.css b/skin/frontend/rwd/default/css/styles.css index 0f0aec2fa3a..b859e05d6df 100644 --- a/skin/frontend/rwd/default/css/styles.css +++ b/skin/frontend/rwd/default/css/styles.css @@ -2668,9 +2668,6 @@ input[type=text] { /* Prevent from zooming on focus */ } } -.ie8 .input-text { - max-width: none; -} /* -------------------------------------------- * * Inputs - Quantity diff --git a/skin/frontend/rwd/default/scss/core/_form.scss b/skin/frontend/rwd/default/scss/core/_form.scss index 32b91a29c14..644255d01a0 100644 --- a/skin/frontend/rwd/default/scss/core/_form.scss +++ b/skin/frontend/rwd/default/scss/core/_form.scss @@ -201,10 +201,6 @@ input[type=text] { } } -.ie8 .input-text { - max-width: none; -} - /* -------------------------------------------- * * Inputs - Quantity */ From c5db926d84c8a65c22bd1ca08018688cda1019f4 Mon Sep 17 00:00:00 2001 From: Justin Beaty Date: Mon, 5 Sep 2022 04:57:02 -0700 Subject: [PATCH 7/9] Re-add global isIE variable --- js/varien/js.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/varien/js.js b/js/varien/js.js index db6cfdf6799..b50a4a66ad1 100644 --- a/js/varien/js.js +++ b/js/varien/js.js @@ -239,6 +239,9 @@ function expandDetails(el, childClass) { } } +// Deprecated since 20.0.17 +var isIE = false; + if (!window.Varien) var Varien = new Object(); From 152dae96730c2e3267f1a1b8eec2f5d58aac8b1c Mon Sep 17 00:00:00 2001 From: Justin Beaty Date: Wed, 5 Oct 2022 13:29:52 -0700 Subject: [PATCH 8/9] Update deprecated comments --- js/mage/adminhtml/loader.js | 4 ++-- js/varien/js.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/mage/adminhtml/loader.js b/js/mage/adminhtml/loader.js index 785d645bc74..9c4b6707b12 100644 --- a/js/mage/adminhtml/loader.js +++ b/js/mage/adminhtml/loader.js @@ -222,11 +222,11 @@ function hideLoader() { } } -// Deprecated since 20.0.17 +/** @deprecated since 20.0.17 */ function setLoaderPosition() { } -// Deprecated since 20.0.17 +/** @deprecated since 20.0.17 */ function toggleSelectsUnderBlock(block, flag) { } diff --git a/js/varien/js.js b/js/varien/js.js index b50a4a66ad1..78296aa071c 100644 --- a/js/varien/js.js +++ b/js/varien/js.js @@ -239,7 +239,7 @@ function expandDetails(el, childClass) { } } -// Deprecated since 20.0.17 +/** @deprecated since 20.0.17 */ var isIE = false; if (!window.Varien) From 752d713a87ccfeb6e63d7ddabc06c6067d8fa343 Mon Sep 17 00:00:00 2001 From: Justin Beaty Date: Sat, 14 Jan 2023 06:33:21 -0800 Subject: [PATCH 9/9] update deprecated since version --- js/mage/adminhtml/loader.js | 4 ++-- js/varien/js.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/mage/adminhtml/loader.js b/js/mage/adminhtml/loader.js index 5ff51a3b756..48279237dce 100644 --- a/js/mage/adminhtml/loader.js +++ b/js/mage/adminhtml/loader.js @@ -223,11 +223,11 @@ function hideLoader() { } } -/** @deprecated since 20.0.17 */ +/** @deprecated since 20.0.19 */ function setLoaderPosition() { } -/** @deprecated since 20.0.17 */ +/** @deprecated since 20.0.19 */ function toggleSelectsUnderBlock(block, flag) { } diff --git a/js/varien/js.js b/js/varien/js.js index 46be0c7162a..d0341144ba3 100644 --- a/js/varien/js.js +++ b/js/varien/js.js @@ -240,7 +240,7 @@ function expandDetails(el, childClass) { } } -/** @deprecated since 20.0.17 */ +/** @deprecated since 20.0.19 */ var isIE = false; if (!window.Varien)