PHP-CS-Fixer: added check for double quotes (#4126)

* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)

* Rector: CQ - UnusedForeachValueToArrayKeysRector

See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector

* fixes + phpstan

See fix at rector: rectorphp/rector-src#6164

* Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)"

This reverts commit 3d7eaf6.

* Convert double-quotes to single-quotes

Author: sreichel

.github/workflows/labeler.yml

@@ -8,6 +8,8 @@
 name: Labeler
 on:
   pull_request_target:
+  # Allow manually triggering the workflow.
+  workflow_dispatch:
 
 jobs:
   triage:

.php-cs-fixer.dist.php

@@ -83,6 +83,8 @@
         'single_import_per_statement' => true,
         // Each namespace use MUST go on its own line and there MUST be one blank line after the use statements block.
         'single_line_after_imports' => true,
+        // Convert double quotes to single quotes for simple strings.
+        'single_quote' => true,
         // Each trait `use` must be done as single statement.
         'single_trait_insert_per_statement' => true,
         // A case should be followed by a colon and not a semicolon.

app/code/core/Mage/Admin/Model/Config.php

@@ -79,7 +79,7 @@ public function __construct()
     public function loadAclResources(Mage_Admin_Model_Acl $acl, $resource = null, $parentName = null)
     {
         if (is_null($resource)) {
-            $resource = $this->getAdminhtmlConfig()->getNode("acl/resources");
+            $resource = $this->getAdminhtmlConfig()->getNode('acl/resources');
             $resourceName = null;
         } else {
             $resourceName = (is_null($parentName) ? '' : $parentName . '/') . $resource->getName();
@@ -117,7 +117,7 @@ public function loadAclResources(Mage_Admin_Model_Acl $acl, $resource = null, $p
      */
     public function getAclAssert($name = '')
     {
-        $asserts = $this->getNode("admin/acl/asserts");
+        $asserts = $this->getNode('admin/acl/asserts');
         if ($name === '') {
             return $asserts;
         }
@@ -133,7 +133,7 @@ public function getAclAssert($name = '')
      */
     public function getAclPrivilegeSet($name = '')
     {
-        $sets = $this->getNode("admin/acl/privilegeSets");
+        $sets = $this->getNode('admin/acl/privilegeSets');
         if ($name === '') {
             return $sets;
         }

app/code/core/Mage/Admin/Model/Observer.php

@@ -55,7 +55,7 @@ public function actionPreDispatchAdmin($observer)
                     /** @var Mage_Core_Model_Session $coreSession */
                     $coreSession = Mage::getSingleton('core/session');
 
-                    if ($coreSession->validateFormKey($request->getPost("form_key"))) {
+                    if ($coreSession->validateFormKey($request->getPost('form_key'))) {
                         $postLogin = $request->getPost('login');
                         $username = $postLogin['username'] ?? '';
                         $password = $postLogin['password'] ?? '';

app/code/core/Mage/Admin/Model/Resource/Acl.php

@@ -148,7 +148,7 @@ public function loadRules(Mage_Admin_Model_Acl $acl, array $rulesArr)
                 Mage::helper('adminhtml')->__(
                     'The following role resources are no longer available in the system: %s. You can delete them by <a href="%s">clicking here</a>.',
                     implode(', ', $orphanedResources),
-                    Mage::helper("adminhtml")->getUrl('adminhtml/permissions_orphanedResource')
+                    Mage::helper('adminhtml')->getUrl('adminhtml/permissions_orphanedResource')
                 )
             );
         }

app/code/core/Mage/Admin/Model/Resource/Roles/Collection.php

@@ -33,7 +33,7 @@ protected function _initSelect()
     {
         parent::_initSelect();
 
-        $this->getSelect()->where("main_table.role_type = ?", 'G');
+        $this->getSelect()->where('main_table.role_type = ?', 'G');
 
         return $this;
     }

app/code/core/Mage/Admin/Model/Resource/Roles/User/Collection.php

@@ -33,7 +33,7 @@ protected function _initSelect()
     {
         parent::_initSelect();
 
-        $this->getSelect()->where("user_id > 0");
+        $this->getSelect()->where('user_id > 0');
 
         return $this;
     }

app/code/core/Mage/Admin/Model/Roles.php

@@ -146,8 +146,8 @@ protected function _buildResourcesArray(
                 }
 
                 if ($rawNodes) {
-                    $resource->addAttribute("aclpath", $resourceName);
-                    $resource->addAttribute("module_c", $module);
+                    $resource->addAttribute('aclpath', $resourceName);
+                    $resource->addAttribute('module_c', $module);
                 }
 
                 if (is_null($represent2Darray)) {

app/code/core/Mage/Admin/sql/admin_setup/upgrade-1.6.1.1-1.6.1.2.php

@@ -28,7 +28,7 @@
     ->addColumn('variable_name', Varien_Db_Ddl_Table::TYPE_VARCHAR, 255, [
         'primary'   => true,
         'nullable'  => false,
-        'default'   => "",
+        'default'   => '',
     ], 'Config Path')
     ->addColumn('is_allowed', Varien_Db_Ddl_Table::TYPE_BOOLEAN, null, [
         'nullable'  => false,
@@ -73,7 +73,7 @@
     ], 'Block ID')
     ->addColumn('block_name', Varien_Db_Ddl_Table::TYPE_VARCHAR, 255, [
         'nullable'  => false,
-        'default'   => "",
+        'default'   => '',
     ], 'Block Name')
     ->addColumn('is_allowed', Varien_Db_Ddl_Table::TYPE_BOOLEAN, null, [
         'nullable'  => false,

app/code/core/Mage/Adminhtml/Block/Api/Editroles.php

@@ -30,7 +30,7 @@ public function __construct()
     protected function _beforeToHtml()
     {
         $roleId = $this->getRequest()->getParam('rid', false);
-        $role = Mage::getModel("api/roles")
+        $role = Mage::getModel('api/roles')
            ->load($roleId);
 
         $this->addTab('info', [