docs: clarify dev setup in README #5165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc122c
added
the
hacktoberfest
FloEdelmann
requested changes
Oct 6, 2025
There was a problem hiding this comment.
I'm not sure this is an improvement. The readme already links to https://github.com/OpenLightingProject/open-fixture-library/blob/master/docs/README.md, where your added information is already included. You can of course improve those files or the link to that file if you think that's necessary.
Apart from that, you removed a lot of links and botched the formatting (compare https://github.com/OpenLightingProject/open-fixture-library/blob/master/README.md with https://github.com/Dannlliam/open-fixture-library/blob/fix/readme-dev-setup/README.md). Please at least fix that before I'll review this again.
|
Okay i will do that shortly , Thank you for your feedback
…On Mon, Oct 6, 2025, 10:25 AM Flo Edelmann ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I'm not sure this is an improvement. The readme already links to
https://github.com/OpenLightingProject/open-fixture-library/blob/master/docs/README.md,
where your added information is already included. You can of course improve
those files or the link to that file if you think that's necessary.
Apart from that, you removed a lot of links and botched the formatting
(compare
https://github.com/OpenLightingProject/open-fixture-library/blob/master/README.md
with
https://github.com/Dannlliam/open-fixture-library/blob/fix/readme-dev-setup/README.md).
Please at least fix that before I'll review this again.
—
Reply to this email directly, view it on GitHub
<#5165 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYF7DUQZFXIDWHK7NRRZEBL3WIKQPAVCNFSM6AAAAACIFWNQQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMBTGE2TSMZYGY>
.
You are receiving this because you authored the thread.Message ID:
<OpenLightingProject/open-fixture-library/pull/5165/review/3303159386@
github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves developer onboarding for new contributors:
These small changes should make it easier for first-time contributors to get a working local environment and to submit fixtures or code changes.
If you prefer different wording or a different Node version note, I'm happy to adjust.