Improve RGB and depth stream parsers

[xlz]

In the RGB stream parser, add an extra check using information the RGB packet footer revealed by new protocol analysis to detect JPEG EOI marker. Then use the marker's position to derive a correct JPEG length for some hardware JPEG decoders that can't handle garbage after the end of JPEG image.

In the depth stream parser, remove the scanning of a 8-byte magic footer which is very unreliable (the particular 8 bytes may appear in the middle) and inefficient. Based on analysis of the isochronous transfer protocol, assume packets have fixed size and the footer always resides at the end of a fixed sized packet. The changes made are minimized, and the execution order in the original parser is preserved, including the order of memcpy's and subsequence/sequence assembling order.

The code has been tested on Linux and Windows.

[christiankerl]

Nice +1 i guess this subsumes the other packet parsing related PRS? However, timestamps are added but not passed through parsers/processors or did I miss something? Could you fix this otherwise?

[xlz]

@christiankerl
I have reorganized the commits so that there is a standalone commit to fully deal with timestamps and sequence numbers.

The RGB commit subsumes #72 and #73. The depth commit subsumes #75. The timestamp/sequence commit subsumes #71 and #148.

[larshg]

This PR works fine at my end 👍

Only cosmetic is to remove the old comment?

[hovren]

I did a quick check, and it seems to be working fine on my end as well (Linux). 👍

[floe]

Also working fine for me (Ubuntu 14.04). @christiankerl since this mostly touches your code, could you do the merge?

[xlz]

Merge conflicts from #227 which changes cosmetic log strings. To fix later.

[floe]

Sorry, didn't realize that - should I revert #227?

[xlz]

No. Fixed conflicts.

[kohrt]

I just tested this pull request and it also solves the issue of restarting the device.

[floe]

OK, sounds like we should integrate this now. I'll give it until today in the evening for any last-minute objections, then I'll merge it.