Fixes analyzer issue: Initial value never used

jobi-wan · jobi-wan · commit 2bd99d0b24fc · 2017-10-15T18:36:38.000+02:00
targetCoordinates is assined a value in its declaration. Its first use is another assignment.
Moved declaration to first assignment that gets used.
diff --git a/src/Core/GuiDisplayGen.m b/src/Core/GuiDisplayGen.m
@@ -1892,10 +1892,9 @@ - (void) drawStarChart:(GLfloat)x :(GLfloat)y :(GLfloat)z :(GLfloat) alpha :(BOO
 	{
 		[self drawAdvancedNavArrayAtX:x+hoffset y:y+voffset z:z alpha:alpha usingRoute:nil optimizedBy:OPTIMIZED_BY_NONE zoom: zoom];
 	}
-	NSPoint targetCoordinates = (NSPoint){0,0};
 	if (!routeExists)
 	{
-		targetCoordinates = [systemManager getCoordinatesForSystem:target inGalaxy:galaxy_id];
+		NSPoint targetCoordinates = [systemManager getCoordinatesForSystem:target inGalaxy:galaxy_id];
 
 		distance = distanceBetweenPlanetPositions(targetCoordinates.x,targetCoordinates.y,galaxy_coordinates.x,galaxy_coordinates.y);
 		if (distance == 0.0)

Original file line number	Diff line number	Diff line change
`@@ -1892,10 +1892,9 @@ - (void) drawStarChart:(GLfloat)x :(GLfloat)y :(GLfloat)z :(GLfloat) alpha :(BOO`
`1892`	`1892`	`{`
`1893`	`1893`	`[self drawAdvancedNavArrayAtX:x+hoffset y:y+voffset z:z alpha:alpha usingRoute:nil optimizedBy:OPTIMIZED_BY_NONE zoom: zoom];`
`1894`	`1894`	`}`
`1895`		`- NSPoint targetCoordinates = (NSPoint){0,0};`
`1896`	`1895`	`if (!routeExists)`
`1897`	`1896`	`{`
`1898`		`- targetCoordinates = [systemManager getCoordinatesForSystem:target inGalaxy:galaxy_id];`
	`1897`	`+ NSPoint targetCoordinates = [systemManager getCoordinatesForSystem:target inGalaxy:galaxy_id];`
`1899`	`1898`
`1900`	`1899`	`distance = distanceBetweenPlanetPositions(targetCoordinates.x,targetCoordinates.y,galaxy_coordinates.x,galaxy_coordinates.y);`
`1901`	`1900`	`if (distance == 0.0)`