Skip to content

Commit edc2ac0

Browse files
david-driscolldavid-driscoll
committed
Remove retry facts!
1 parent 6004faa commit edc2ac0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+233
-605
lines changed

‎test/Dap.Tests/Integration/ConnectionAndDisconnectionTests.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public ConnectionAndDisconnectionTests(ITestOutputHelper outputHelper) : base(
2222
{
2323
}
2424

25-
[RetryFact]
25+
[Fact]
2626
public async Task Server_Should_Stay_Alive_When_Requests_Throw_An_Exception()
2727
{
2828
var (client, _) = await Initialize(ConfigureClient, ConfigureServer);
@@ -37,7 +37,7 @@ public async Task Server_Should_Stay_Alive_When_Requests_Throw_An_Exception()
3737
result.Should().BeTrue();
3838
}
3939

40-
[RetryFact]
40+
[Fact]
4141
public async Task Client_Should_Stay_Alive_When_Requests_Throw_An_Exception()
4242
{
4343
var (_, server) = await Initialize(ConfigureClient, ConfigureServer);
@@ -52,7 +52,7 @@ public async Task Client_Should_Stay_Alive_When_Requests_Throw_An_Exception()
5252
result.Should().BeTrue();
5353
}
5454

55-
[RetryFact]
55+
[Fact]
5656
public async Task Server_Should_Support_Links()
5757
{
5858
var (client, _) = await Initialize(ConfigureClient, ConfigureServer);
@@ -67,7 +67,7 @@ public async Task Server_Should_Support_Links()
6767
result.Should().BeTrue();
6868
}
6969

70-
[RetryFact]
70+
[Fact]
7171
public async Task Client_Should_Support_Links()
7272
{
7373
var (_, server) = await Initialize(ConfigureClient, ConfigureServer);

‎test/Dap.Tests/Integration/CustomRequestsTests.cs‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public CustomRequestsTests(ITestOutputHelper outputHelper) : base(new JsonRpcTes
2020
{
2121
}
2222

23-
[RetryFact]
23+
[Fact]
2424
public async Task Should_Support_Custom_Attach_Request_Using_Base_Class()
2525
{
2626
var fake = Substitute.For<AttachHandlerBase<CustomAttachRequestArguments>>();
@@ -42,7 +42,7 @@ await client.Attach(
4242
request.ProcessId.Should().Be("4321");
4343
}
4444

45-
[RetryFact]
45+
[Fact]
4646
public async Task Should_Support_Custom_Attach_Request_Receiving_Regular_Request_Using_Base_Class()
4747
{
4848
var fake = Substitute.For<AttachHandlerBase>();
@@ -64,7 +64,7 @@ await client.Attach(
6464
request.ExtensionData.Should().ContainKey("processId").And.Subject["processId"].Should().Be("4321");
6565
}
6666

67-
[RetryFact]
67+
[Fact]
6868
public async Task Should_Support_Custom_Attach_Request_Using_Extension_Data_Using_Base_Class()
6969
{
7070
var fake = Substitute.For<AttachHandlerBase<CustomAttachRequestArguments>>();
@@ -88,7 +88,7 @@ await client.Attach(
8888
request.ProcessId.Should().Be("4321");
8989
}
9090

91-
[RetryFact]
91+
[Fact]
9292
public async Task Should_Support_Custom_Launch_Request_Using_Base_Class()
9393
{
9494
var fake = Substitute.For<LaunchHandlerBase<CustomLaunchRequestArguments>>();
@@ -106,7 +106,7 @@ await client.Launch(
106106
request.Script.Should().Be("build.ps1");
107107
}
108108

109-
[RetryFact]
109+
[Fact]
110110
public async Task Should_Support_Custom_Launch_Request_Receiving_Regular_Request_Using_Base_Class()
111111
{
112112
var fake = Substitute.For<LaunchHandlerBase>();
@@ -124,7 +124,7 @@ await client.Launch(
124124
request.ExtensionData.Should().ContainKey("script").And.Subject["script"].Should().Be("build.ps1");
125125
}
126126

127-
[RetryFact]
127+
[Fact]
128128
public async Task Should_Support_Custom_Launch_Request_Using_Extension_Data_Base_Class()
129129
{
130130
var fake = Substitute.For<LaunchHandlerBase<CustomLaunchRequestArguments>>();
@@ -144,7 +144,7 @@ await client.Launch(
144144
request.Script.Should().Be("build.ps1");
145145
}
146146

147-
[RetryFact]
147+
[Fact]
148148
public async Task Should_Support_Custom_Attach_Request_Using_Delegate()
149149
{
150150
var fake = Substitute.For<Func<CustomAttachRequestArguments, CancellationToken, Task<AttachResponse>>>();
@@ -166,7 +166,7 @@ await client.Attach(
166166
request.ProcessId.Should().Be("4321");
167167
}
168168

169-
[RetryFact]
169+
[Fact]
170170
public async Task Should_Support_Custom_Attach_Request_Receiving_Regular_Request_Using_Delegate()
171171
{
172172
var fake = Substitute.For<Func<AttachRequestArguments, CancellationToken, Task<AttachResponse>>>();
@@ -188,7 +188,7 @@ await client.Attach(
188188
request.ExtensionData.Should().ContainKey("processId").And.Subject["processId"].Should().Be("4321");
189189
}
190190

191-
[RetryFact]
191+
[Fact]
192192
public async Task Should_Support_Custom_Attach_Request_Using_Extension_Data_Using_Delegate()
193193
{
194194
var fake = Substitute.For<Func<CustomAttachRequestArguments, CancellationToken, Task<AttachResponse>>>();
@@ -212,7 +212,7 @@ await client.Attach(
212212
request.ProcessId.Should().Be("4321");
213213
}
214214

215-
[RetryFact]
215+
[Fact]
216216
public async Task Should_Support_Custom_Launch_Request_Using_Delegate()
217217
{
218218
var fake = Substitute.For<Func<CustomLaunchRequestArguments, CancellationToken, Task<LaunchResponse>>>();
@@ -230,7 +230,7 @@ await client.Launch(
230230
request.Script.Should().Be("build.ps1");
231231
}
232232

233-
[RetryFact]
233+
[Fact]
234234
public async Task Should_Support_Custom_Launch_Request_Receiving_Regular_Request_Using_Delegate()
235235
{
236236
var fake = Substitute.For<Func<LaunchRequestArguments, CancellationToken, Task<LaunchResponse>>>();
@@ -248,7 +248,7 @@ await client.Launch(
248248
request.ExtensionData.Should().ContainKey("script").And.Subject["script"].Should().Be("build.ps1");
249249
}
250250

251-
[RetryFact]
251+
[Fact]
252252
public async Task Should_Support_Custom_Launch_Request_Using_Extension_Data_Using_Delegate()
253253
{
254254
var fake = Substitute.For<Func<CustomLaunchRequestArguments, CancellationToken, Task<LaunchResponse>>>();

‎test/Dap.Tests/Integration/GenericDapServerTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public GenericDapServerTests(ITestOutputHelper outputHelper) : base(new JsonRpcT
1717
{
1818
}
1919

20-
[RetryFact]
20+
[Fact]
2121
public async Task Supports_Multiple_Handlers_On_A_Single_Class()
2222
{
2323
var handler = new Handler();

‎test/Dap.Tests/Integration/HandlersManagerIntegrationTests.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public HandlersManagerIntegrationTests(ITestOutputHelper testOutputHelper) : bas
1919
{
2020
}
2121

22-
[RetryFact]
22+
[Fact]
2323
public async Task Should_Return_Default_Handlers()
2424
{
2525
var (_, server) = await Initialize(options => {}, options => {});
@@ -29,7 +29,7 @@ public async Task Should_Return_Default_Handlers()
2929
handlersManager.GetHandlers().Should().HaveCount(2);
3030
}
3131

32-
[RetryFact]
32+
[Fact]
3333
public async Task Link_Should_Fail_If_No_Handler_Is_Defined()
3434
{
3535
var (_, server) = await Initialize(options => {}, options => {});
@@ -40,7 +40,7 @@ public async Task Link_Should_Fail_If_No_Handler_Is_Defined()
4040
a.Should().Throw<ArgumentException>().Which.Message.Should().Contain("Descriptors must be registered before links can be created");
4141
}
4242

43-
[RetryFact]
43+
[Fact]
4444
public async Task Link_Should_Fail_If_Link_Is_On_The_Wrong_Side()
4545
{
4646
var (_, server) = await Initialize(options => {}, options => {});

‎test/Dap.Tests/Integration/RequestCancellationTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public RequestCancellationTests(ITestOutputHelper outputHelper) : base(new JsonR
2121
{
2222
}
2323

24-
[RetryFact]
24+
[Fact]
2525
public async Task Should_Cancel_Pending_Requests()
2626
{
2727
var (client, _) = await Initialize(ConfigureClient, ConfigureServer);

‎test/JsonRpc.Tests/IntegrationTests.cs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ private class Data
3030
public string Value { get; set; } = null!;
3131
}
3232

33-
[RetryFact]
33+
[Fact]
3434
public async Task Should_Send_and_receive_requests()
3535
{
3636
var (client, server) = await Initialize(
@@ -45,7 +45,7 @@ public async Task Should_Send_and_receive_requests()
4545
clientResponse.Value.Should().Be("myresponse");
4646
}
4747

48-
[RetryFact]
48+
[Fact]
4949
public async Task Should_throw_when_sending_requests()
5050
{
5151
var (client, server) = await Initialize(
@@ -60,7 +60,7 @@ public async Task Should_throw_when_sending_requests()
6060
serverRequest.Should().Throw<InvalidParametersException>();
6161
}
6262

63-
[RetryFact]
63+
[Fact]
6464
public async Task Should_throw_when_receiving_requests()
6565
{
6666
var (client, server) = await Initialize(
@@ -75,7 +75,7 @@ public async Task Should_throw_when_receiving_requests()
7575
serverRequest.Should().Throw<InternalErrorException>();
7676
}
7777

78-
[RetryFact]
78+
[Fact]
7979
public async Task Should_Send_and_receive_notifications()
8080
{
8181
var clientNotification = new AsyncSubject<Data>();
@@ -108,7 +108,7 @@ public async Task Should_Send_and_receive_notifications()
108108
clientResponse.Value.Should().Be("esnopserym");
109109
}
110110

111-
[RetryFact]
111+
[Fact]
112112
public async Task Should_Send_and_cancel_requests_immediate()
113113
{
114114
var (client, server) = await Initialize(
@@ -144,7 +144,7 @@ public async Task Should_Send_and_cancel_requests_immediate()
144144
}
145145
}
146146

147-
[RetryFact]
147+
[Fact]
148148
public async Task Should_Send_and_cancel_requests_from_otherside()
149149
{
150150
var (client, server) = await Initialize(
@@ -181,7 +181,7 @@ public async Task Should_Send_and_cancel_requests_from_otherside()
181181
}
182182
}
183183

184-
[RetryFact]
184+
[Fact]
185185
public async Task Should_Cancel_Parallel_Requests_When_Options_Are_Given()
186186
{
187187
var (client, server) = await Initialize(
@@ -232,7 +232,7 @@ public async Task Should_Cancel_Parallel_Requests_When_Options_Are_Given()
232232
}
233233
}
234234

235-
[RetryFact]
235+
[Fact]
236236
public async Task Should_Link_Request_A_to_Request_B()
237237
{
238238
var (client, server) = await Initialize(

‎test/Lsp.Tests/Integration/ConnectionAndDisconnectionTests.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public ConnectionAndDisconnectionTests(ITestOutputHelper outputHelper) : base(
2222
{
2323
}
2424

25-
[RetryFact]
25+
[Fact]
2626
public async Task Server_Should_Stay_Alive_When_Requests_Throw_An_Exception()
2727
{
2828
var (client, _) = await Initialize(ConfigureClient, ConfigureServer);
@@ -37,7 +37,7 @@ public async Task Server_Should_Stay_Alive_When_Requests_Throw_An_Exception()
3737
result.Should().BeTrue();
3838
}
3939

40-
[RetryFact]
40+
[Fact]
4141
public async Task Client_Should_Stay_Alive_When_Requests_Throw_An_Exception()
4242
{
4343
var (_, server) = await Initialize(ConfigureClient, ConfigureServer);
@@ -52,7 +52,7 @@ public async Task Client_Should_Stay_Alive_When_Requests_Throw_An_Exception()
5252
result.Should().BeTrue();
5353
}
5454

55-
[RetryFact]
55+
[Fact]
5656
public async Task Server_Should_Support_Links()
5757
{
5858
var (client, _) = await Initialize(ConfigureClient, ConfigureServer);
@@ -67,7 +67,7 @@ public async Task Server_Should_Support_Links()
6767
result.Should().BeTrue();
6868
}
6969

70-
[RetryFact]
70+
[Fact]
7171
public async Task Client_Should_Support_Links()
7272
{
7373
var (_, server) = await Initialize(ConfigureClient, ConfigureServer);

‎test/Lsp.Tests/Integration/CustomRequestsTests.cs‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
using OmniSharp.Extensions.LanguageServer.Protocol.Models;
1111
using OmniSharp.Extensions.LanguageServer.Protocol.Window;
1212
using TestingUtils;
13+
using Xunit;
1314
using Xunit.Abstractions;
1415

1516
namespace Lsp.Tests.Integration
@@ -20,7 +21,7 @@ public CustomRequestsTests(ITestOutputHelper outputHelper) : base(new JsonRpcTes
2021
{
2122
}
2223

23-
[RetryFact]
24+
[Fact]
2425
public async Task Should_Support_Custom_Telemetry_Using_Base_Class()
2526
{
2627
var fake = Substitute.For<TelemetryEventHandlerBase<CustomTelemetryEventParams>>();
@@ -44,7 +45,7 @@ public async Task Should_Support_Custom_Telemetry_Using_Base_Class()
4445
.Should().BeEquivalentTo(@event, z => z.UsingStructuralRecordEquality().Excluding(x => x.ExtensionData));
4546
}
4647

47-
[RetryFact]
48+
[Fact]
4849
public async Task Should_Support_Custom_Telemetry_Receiving_Regular_Telemetry_Using_Base_Class()
4950
{
5051
var fake = Substitute.For<TelemetryEventHandlerBase>();
@@ -70,7 +71,7 @@ public async Task Should_Support_Custom_Telemetry_Receiving_Regular_Telemetry_Us
7071
request.ExtensionData.Should().ContainKey("promptToUpdatePackageManagement").And.Subject["promptToUpdatePackageManagement"].Should().Be(false);
7172
}
7273

73-
[RetryFact]
74+
[Fact]
7475
public async Task Should_Support_Custom_Telemetry_Using_Extension_Data_Using_Base_Class()
7576
{
7677
var fake = Substitute.For<TelemetryEventHandlerBase<CustomTelemetryEventParams>>();
@@ -99,7 +100,7 @@ public async Task Should_Support_Custom_Telemetry_Using_Extension_Data_Using_Bas
99100
request.PromptToUpdatePackageManagement.Should().Be(false);
100101
}
101102

102-
[RetryFact]
103+
[Fact]
103104
public async Task Should_Support_Custom_Telemetry_Using_Delegate()
104105
{
105106
var fake = Substitute.For<Func<CustomTelemetryEventParams, CancellationToken, Task>>();
@@ -123,7 +124,7 @@ public async Task Should_Support_Custom_Telemetry_Using_Delegate()
123124
.Should().BeEquivalentTo(@event, z => z.UsingStructuralRecordEquality().Excluding(x => x.ExtensionData));
124125
}
125126

126-
[RetryFact]
127+
[Fact]
127128
public async Task Should_Support_Custom_Telemetry_Receiving_Regular_Telemetry_Using_Delegate()
128129
{
129130
var fake = Substitute.For<Func<TelemetryEventParams, CancellationToken, Task>>();
@@ -149,7 +150,7 @@ public async Task Should_Support_Custom_Telemetry_Receiving_Regular_Telemetry_Us
149150
request.ExtensionData.Should().ContainKey("promptToUpdatePackageManagement").And.Subject["promptToUpdatePackageManagement"].Should().Be(false);
150151
}
151152

152-
[RetryFact]
153+
[Fact]
153154
public async Task Should_Support_Custom_Telemetry_Using_Extension_Data_Using_Delegate()
154155
{
155156
var fake = Substitute.For<Func<CustomTelemetryEventParams, CancellationToken, Task>>();

0 commit comments

Comments
 (0)