fix: typo in style example #3144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrelmiller
approved these changes
Jan 19, 2023
Member
|
@webron Can you merge? |
MikeRalphson
approved these changes
Mar 3, 2023
charjr
pushed a commit
to charjr/OpenAPI-Specification
that referenced
this pull request
Apr 27, 2023
charjr
pushed a commit
to charjr/OpenAPI-Specification
that referenced
this pull request
Apr 27, 2023
Member
|
Are you sure about this? It's really not dots all the way through? I just filed swagger-api/swagger.io-docs#342 which makes the reverse change. |
Member
|
and it looks like this still needs to be added to the v3.2.0-dev branch? |
Member
|
@karenetheridge Its dots all the way when explode =true but not otherwise https://www.rfc-editor.org/rfc/rfc6570#section-3.2.5 |
handrews
added
bug
examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example for style=label, explode=false in https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#style-examples is incorrect, see comment #1508 (comment) from @darrelmiller and the examples in https://swagger.io/docs/specification/serialization/.
The latter source states the RFC6570 template for style=label, explode=false as
{.id}for a parameter namedid, which is consistent with using commas as separators after the leading dot.Fixes #3139
Thanks to @pk-work for finding this typo.