Merge pull request #4719 from ralfhandl/dev-determine-dialect

dev: don't hard-code vocabulary in test code

Author: handrews

tests/schema/schema.test.mjs

@@ -1,7 +1,7 @@
 import { readdirSync, readFileSync } from "node:fs";
 import YAML from "yaml";
 import { registerSchema, validate, setMetaSchemaOutputFormat } from "@hyperjump/json-schema/openapi-3-1";
-import { BASIC, addKeyword, defineVocabulary } from "@hyperjump/json-schema/experimental";
+import { BASIC, defineVocabulary } from "@hyperjump/json-schema/experimental";
 import { describe, test, expect } from "vitest";
 
 import contentTypeParser from "content-type";
@@ -26,63 +26,20 @@ const parseYamlFromFile = (filePath) => {
 
 setMetaSchemaOutputFormat(BASIC);
 
-addKeyword({
-  id: "https://spec.openapis.org/oas/schema/vocab/keyword/discriminator",
-  interpret: (discriminator, instance, context) => {
-    return true;
-  },
-  /* discriminator is not exactly an annotation, but it's not allowed
-   * to change the validation outcome (hence returing true from interopret())
-   * and for our purposes of testing, this is sufficient.
-   */
-  annotation: (discriminator) => {
-    return discriminator;
-  },
-});
-
-addKeyword({
-  id: "https://spec.openapis.org/oas/schema/vocab/keyword/example",
-  interpret: (example, instance, context) => {
-    return true;
-  },
-  annotation: (example) => {
-    return example;
-  },
-});
+const meta = parseYamlFromFile("./src/schemas/validation/meta.yaml");
+const oasBaseVocab = Object.keys(meta.$vocabulary)[0];
 
-addKeyword({
-  id: "https://spec.openapis.org/oas/schema/vocab/keyword/externalDocs",
-  interpret: (externalDocs, instance, context) => {
-    return true;
-  },
-  annotation: (externalDocs) => {
-    return externalDocs;
-  },
+defineVocabulary(oasBaseVocab, {
+  "discriminator": "https://spec.openapis.org/oas/3.0/keyword/discriminator",
+  "example": "https://spec.openapis.org/oas/3.0/keyword/example",
+  "externalDocs": "https://spec.openapis.org/oas/3.0/keyword/externalDocs",
+  "xml": "https://spec.openapis.org/oas/3.0/keyword/xml"
 });
 
-addKeyword({
-  id: "https://spec.openapis.org/oas/schema/vocab/keyword/xml",
-  interpret: (xml, instance, context) => {
-    return true;
-  },
-  annotation: (xml) => {
-    return xml;
-  },
-});
-
-defineVocabulary(
-  "https://spec.openapis.org/oas/3.1/vocab/base",
-  {
-    "discriminator": "https://spec.openapis.org/oas/schema/vocab/keyword/discriminator",
-    "example": "https://spec.openapis.org/oas/schema/vocab/keyword/example",
-    "externalDocs": "https://spec.openapis.org/oas/schema/vocab/keyword/externalDocs",
-    "xml": "https://spec.openapis.org/oas/schema/vocab/keyword/xml",
-  },
-);
-
-registerSchema(parseYamlFromFile("./src/schemas/validation/meta.yaml"));
+registerSchema(meta);
 registerSchema(parseYamlFromFile("./src/schemas/validation/dialect.yaml"));
 registerSchema(parseYamlFromFile("./src/schemas/validation/schema.yaml"));
+
 const validateOpenApi = await validate("./src/schemas/validation/schema-base.yaml");
 const fixtures = './tests/schema';