Skip to content

Conversation

@NobodyXu
Copy link
Collaborator

No description provided.

@NobodyXu NobodyXu requested a review from robjtede August 24, 2025 08:51
}
}

impl_async_buf_write!(AsyncBufWriteTokio);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workaround is necessary to prevent conflicting implementation of trait error.

Without this, we would have to duplicate BufWriter struct, which defeats the purpose of this refactor.

@robjtede
Copy link
Member

robjtede commented Sep 1, 2025

Conflicts have arisen. I'll check this out after resolution.

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Sep 2, 2025

cc @jkushmaul I don't have time to push this now; if you want to pick it up you can create a new branch and simply copy the files over, it would be faster than manually resolv3z

@NobodyXu
Copy link
Collaborator Author

Closing this as I will pursue a more radical solution

@NobodyXu NobodyXu closed this Sep 24, 2025
@NobodyXu NobodyXu deleted the refactor branch September 24, 2025 11:07
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (ccefbeb) to head (39274e5).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #377   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants