fix problem with /exp:agg #668
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwertheimer
requested changes
Aug 7, 2025
Collaborator
dwertheimer
left a comment
dwertheimer
left a comment
There was a problem hiding this comment.
@Bono2007 Thanks for putting this PR together. I'd like to be able to release an update, so can you please add a couple more changed files and push to this branch on github to update the PR?
expenses.js:
Add back in the Flow typing on line 144
Thanks!
plugin.json:
- bump the version number
- add a lastUpdate message about what this update fixes
changelog:
- add a line in the changelog for this update
I don't think any changes in the README are necessary, but if you do, please make those changes.
Thanks!
David
dwertheimer
reviewed
Aug 7, 2025
|
|
||
| return false | ||
| } | ||
| const expensesAggregate = async () => { |
Collaborator
There was a problem hiding this comment.
Function needs typing (see original code):
: Promise<boolean>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.