Move and rename elasticstack_enable_repos to the repos role

This variable is only part of the `repos` role. There is no need to
define it inside the `elasticstack` role.

Author: tbauriedel

docs/10-role-repos.md

@@ -1,12 +1,8 @@
-Elastic Repos
-=========
+# Role `repos`
 
-![Test Role repos](https://github.com/netways/ansible-collection-elasticstack/actions/workflows/test_role_repos.yml/badge.svg)
+This role will add the Elastic repositories to the package manager (dnf/yum. apt or zypper). It will not install packages (these can be done with the role `elasticsearch`).
 
-The role adds Elastic repositories to the package manager. It's main use is in connection with other roles that provide installation and configuration of the Elastic Stack.
-
-Requirements
-------------
+## Requirements
 
 GPG needs to be installed on the systems to verify the package signature. This will be installed as part of the role. Below you can find a list of packages that will be installed.
 * Debian family: `apt-transport-https`, `gpg` and `gpg-agent`
@@ -15,25 +11,28 @@ GPG needs to be installed on the systems to verify the package signature. This w
 
 For SuSE hosts you will need the Ansible collection `community.general` on your Ansible controller.
 
-Role Variables
---------------
+## Variables
+
+There are variables that are needed in more than one role of the collection. These are defined inside the "meta" role `elasticstack`. The role `elasticstack` is imported in this role.
 
-* *elasticstack_release*: Major release version of Elastic stack to configure. (default: `7`). `7` and `8` are supported.
-* *elasticstack_variant*: Variant of the stack to install. Valid values: `elastic` or `oss`. (default: `elastic`).
-* *elasticstack_enable_repos*: Enable repositories after creating them. (default: `true`) Only works on RPM based distributions!
+**List of variables from `elasticsearch` used inside `repos`:**
+* `elasticstack_release`: Major release version of Elastic stack to configure. (default: `7`). `7` and `8` are supported.
+* `elasticstack_variant`: Variant of the stack to install. Valid values: `elastic` or `oss`. (default: `elastic`).
 
 Please note that no `oss` versions are available for Elastic Stack later than `7`. This role will fail if you try to install them.
 
-Usage
---------
+**Variables that are explicity defined inside `repos`:**
+* `repos_enable_repos`: Enable repositories after creating them. Only works on RPM based distributions (default: `true`) 
+
+## Usage
 
-Upgrades
-========
+### Upgrades
 
-If you want to be able to update your operating system without worrying about accidentally upgrading Elastic Stack, set `elasticstack_enable_repos` to `false`. The roles in this collection will enable the repository in case they need it. Keep in mind that this will only work on rpm based distributions.
+If you want to be able to update your operating system without worrying about accidentally upgrading Elastic Stack, set `repos_enable_repos` to `false`. The roles in this collection will enable the repository in case they need it. Keep in mind that this will only work on rpm based distributions.
 
-Example playbook
-================
+### Example playbook
+
+The following playbook will add the Elastic repository to the package manager.
 
 ```
   - hosts: all
@@ -42,4 +41,4 @@ Example playbook
       - netways.elasticstack
     roles:
       - repos
-```
+```

roles/elasticstack/defaults/main.yml

@@ -13,7 +13,6 @@ elasticstack_ca_pass: PleaseChangeMe
 elasticstack_ca_validity_period: 1095
 elasticstack_ca_will_expire_soon: false
 elasticstack_elasticsearch_http_port: 9200
-elasticstack_enable_repos: true
 elasticstack_collection_managed: true
 elasticstack_initial_passwords: /usr/share/elasticsearch/initial_passwords
 elasticstack_kibana_port: 5601

roles/repos/tasks/redhat.yml

@@ -12,7 +12,7 @@
     baseurl: https://artifacts.elastic.co/packages/{{ elasticstack_release }}.x/yum
     gpgcheck: yes
     gpgkey: "{{ elasticstack_repo_key }}"
-    enabled: "{{ elasticstack_enable_repos | bool }}"
+    enabled: "{{ repos_enable_repos | bool }}"
   when: elasticstack_variant == "elastic"
 
 - name: Ensure Elastic Stack OSS yum repository is configured (RedHat)
@@ -23,5 +23,5 @@
     baseurl: https://artifacts.elastic.co/packages/oss-{{ elasticstack_release }}.x/yum
     gpgcheck: yes
     gpgkey: "{{ elasticstack_repo_key }}"
-    enabled: "{{ elasticstack_enable_repos | bool }}"
+    enabled: "{{ repos_enable_repos | bool }}"
   when: elasticstack_variant == "oss"

roles/repos/tasks/suse.yml

@@ -5,7 +5,7 @@
     description: Elastic Release {{ elasticstack_release }}.x
     repo: https://artifacts.elastic.co/packages/{{ elasticstack_release }}.x/yum
     auto_import_keys: true
-    enabled: "{{ elasticstack_enable_repos | bool }}"
+    enabled: "{{ repos_enable_repos | bool }}"
   when: elasticstack_variant == "elastic"
 
 - name: Ensure Elastic Stack OSS yum repository is configured (SuSE)
@@ -14,5 +14,5 @@
     description: Elastic OSS Release {{ elasticstack_release }}.x
     repo: https://artifacts.elastic.co/packages/oss-{{ elasticstack_release }}.x/yum
     auto_import_keys: true
-    enabled: "{{ elasticstack_enable_repos | bool }}"
+    enabled: "{{ repos_enable_repos | bool }}"
   when: elasticstack_variant == "oss"