Fix object rest enumeration #29676
Merged
Fix object rest enumeration #29676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
When this PR lands, the same change should be made to |
NicholasLYang
force-pushed
the
fixObjectRestEnumeration
branch
from
2b646cd to
bf12ce1
Compare
NicholasLYang
force-pushed
the
fixObjectRestEnumeration
branch
from
3332029 to
d1e5150
Compare
rbuckton
suggested changes
Apr 26, 2019
| for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) if (e.indexOf(p[i]) < 0) | ||
| t[p[i]] = s[p[i]]; | ||
| for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) { | ||
| if (e.indexOf(p[i]) < 0 && Object.prototype.propertyIsEnumerable(p[i])) |
Contributor
There was a problem hiding this comment.
This is incorrect as you are passing the wrong receiver. Its highly unlikely p[i] is enumerable on Object.prototype. You probably mean this:
Suggested change
| if (e.indexOf(p[i]) < 0 && Object.prototype.propertyIsEnumerable(p[i])) | |
| if (e.indexOf(p[i]) < 0 && Object.prototype.propertyIsEnumerable.call(s, p[i])) |
Contributor
Author
There was a problem hiding this comment.
Ah, makes sense. In that case, does s.propertyIsEnumerable(p[i]) work as well?
Contributor
Author
There was a problem hiding this comment.
On second thought, I suppose s could have its own implementation of propertyIsEnumerable, so no, that probably does not work.
Contributor
|
As @ajafff mentioned above, you should also open a PR against https://github.com/Microsoft/tslib for the same change: |
NicholasLYang
force-pushed
the
fixObjectRestEnumeration
branch
from
d1e5150 to
32bcd41
Compare
Contributor
|
It looks like you still have some failing tests. |
…ent enumerable symbols from sneaking through.
NicholasLYang
force-pushed
the
fixObjectRestEnumeration
branch
from
32bcd41 to
61e1009
Compare
Contributor
Author
|
Yep, sorry. Fixed! |
This was referenced Sep 23, 2019
This was referenced Mar 25, 2020
This was referenced Apr 7, 2020
This was referenced Apr 17, 2020
This was referenced Apr 28, 2020
This was referenced May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Bug' or 'help wanted' or is in the Community milestone
masterbranchjake runtestslocallyFixes #29616
Adjusts the __rest function in destructuring.ts to check if property is enumerable.