Skip to content

Seedless controller: Add "@noble" dependencies as main dependencies #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Seedless controller: Add "@noble" dependencies as main dependencies #6101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbfc9c2
add @noble dependencies
matthiasgeihs Jul 10, 2025
bde9f0f
upgrade @noble dependencies
matthiasgeihs Jul 14, 2025
616a9d2
fixup yarn.lock
matthiasgeihs Jul 14, 2025
42200c9
update changelogs
matthiasgeihs Jul 15, 2025
29a2046
fixup seedless changelog
matthiasgeihs Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/phishing-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Bump `@noble/hashes` from `^1.4.0` to `^1.8.0` ([#6101](https://github.com/MetaMask/core/pull/6101))

## [13.1.0]

### Added
Expand Down
2 changes: 1 addition & 1 deletion packages/phishing-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"dependencies": {
"@metamask/base-controller": "^8.0.1",
"@metamask/controller-utils": "^11.11.0",
"@noble/hashes": "^1.4.0",
"@noble/hashes": "^1.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: instead of using no-changelog could we add a changelog entry for this bump

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"@types/punycode": "^2.1.0",
"ethereum-cryptography": "^2.1.2",
"fastest-levenshtein": "^1.0.16",
Expand Down
5 changes: 5 additions & 0 deletions packages/profile-sync-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Bump `@noble/hashes` from `^1.4.0` to `^1.8.0` ([#6101](https://github.com/MetaMask/core/pull/6101))
- Bump `@noble/ciphers` from `^0.5.2` to `^1.3.0` ([#6101](https://github.com/MetaMask/core/pull/6101))

## [21.0.0]

### Added
Expand Down
4 changes: 2 additions & 2 deletions packages/profile-sync-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@
"@metamask/base-controller": "^8.0.1",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-utils": "^11.0.0",
"@noble/ciphers": "^0.5.2",
"@noble/hashes": "^1.4.0",
"@noble/ciphers": "^1.3.0",
"@noble/hashes": "^1.8.0",
Comment on lines +106 to +107
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: instead of using no-changelog could we add a changelog entries for these bumps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"immer": "^9.0.6",
"loglevel": "^1.8.1",
"siwe": "^2.3.2"
Expand Down
6 changes: 6 additions & 0 deletions packages/seedless-onboarding-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Moved `@noble/hashes` from dev dependencies to main dependencies and bumped from `^1.4.0` to `^1.8.0` ([#6101](https://github.com/MetaMask/core/pull/6101))
- Moved `@noble/ciphers` from dev dependencies to main dependencies and bumped from `^0.5.2` to `^1.3.0` ([#6101](https://github.com/MetaMask/core/pull/6101))
- Moved `@noble/curves` from dev dependencies to main dependencies and bumped from `^1.2.0` to `^1.9.2` ([#6101](https://github.com/MetaMask/core/pull/6101))

## [2.1.0]

### Added
Expand Down
6 changes: 3 additions & 3 deletions packages/seedless-onboarding-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@
"@metamask/base-controller": "^8.0.1",
"@metamask/toprf-secure-backup": "^0.6.0",
"@metamask/utils": "^11.4.2",
"@noble/ciphers": "^1.3.0",
"@noble/curves": "^1.9.2",
"@noble/hashes": "^1.8.0",
Comment on lines +54 to +56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: instead of using no-changelog could we add a changelog entries for these bumps and that they are being now used as dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"async-mutex": "^0.5.0"
},
"devDependencies": {
Expand All @@ -59,9 +62,6 @@
"@metamask/auto-changelog": "^3.4.4",
"@metamask/browser-passworder": "^4.3.0",
"@metamask/keyring-controller": "^22.1.0",
"@noble/ciphers": "^0.5.2",
"@noble/curves": "^1.2.0",
"@noble/hashes": "^1.4.0",
"@types/elliptic": "^6",
"@types/jest": "^27.4.1",
"@types/json-stable-stringify-without-jsonify": "^1.0.2",
Expand Down
52 changes: 19 additions & 33 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4094,7 +4094,7 @@ __metadata:
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^8.0.1"
"@metamask/controller-utils": "npm:^11.11.0"
"@noble/hashes": "npm:^1.4.0"
"@noble/hashes": "npm:^1.8.0"
"@types/jest": "npm:^27.4.1"
"@types/punycode": "npm:^2.1.0"
deepmerge: "npm:^4.2.2"
Expand Down Expand Up @@ -4184,8 +4184,8 @@ __metadata:
"@metamask/snaps-controllers": "npm:^14.0.1"
"@metamask/snaps-sdk": "npm:^9.0.0"
"@metamask/snaps-utils": "npm:^11.0.0"
"@noble/ciphers": "npm:^0.5.2"
"@noble/hashes": "npm:^1.4.0"
"@noble/ciphers": "npm:^1.3.0"
"@noble/hashes": "npm:^1.8.0"
"@types/jest": "npm:^27.4.1"
deepmerge: "npm:^4.2.2"
ethers: "npm:^6.12.0"
Expand Down Expand Up @@ -4331,9 +4331,9 @@ __metadata:
"@metamask/keyring-controller": "npm:^22.1.0"
"@metamask/toprf-secure-backup": "npm:^0.6.0"
"@metamask/utils": "npm:^11.4.2"
"@noble/ciphers": "npm:^0.5.2"
"@noble/curves": "npm:^1.2.0"
"@noble/hashes": "npm:^1.4.0"
"@noble/ciphers": "npm:^1.3.0"
"@noble/curves": "npm:^1.9.2"
"@noble/hashes": "npm:^1.8.0"
"@types/elliptic": "npm:^6"
"@types/jest": "npm:^27.4.1"
"@types/json-stable-stringify-without-jsonify": "npm:^1.0.2"
Expand Down Expand Up @@ -4753,17 +4753,10 @@ __metadata:
languageName: node
linkType: hard

"@noble/ciphers@npm:^0.5.2":
version: 0.5.3
resolution: "@noble/ciphers@npm:0.5.3"
checksum: 10/af0ad96b5807feace93e63549e05de6f5e305b36e2e95f02d90532893fbc3af3f19b9621b6de4caa98303659e5df2e7aa082064e5d4a82e6f38c728d48dfae5d
languageName: node
linkType: hard

"@noble/ciphers@npm:^1.2.1":
version: 1.2.1
resolution: "@noble/ciphers@npm:1.2.1"
checksum: 10/7fa0d32529d8da6323b08afec97218f6d6bc0d1e135243bf10f7587a2819495c3f3f4a5af1f41045501bb1ade94238c76960366a5d6441970e49ba9cacb88740
"@noble/ciphers@npm:^1.2.1, @noble/ciphers@npm:^1.3.0":
version: 1.3.0
resolution: "@noble/ciphers@npm:1.3.0"
checksum: 10/051660051e3e9e2ca5fb9dece2885532b56b7e62946f89afa7284a0fb8bc02e2bd1c06554dba68162ff42d295b54026456084198610f63c296873b2f1cd7a586
languageName: node
linkType: hard

Expand All @@ -4785,12 +4778,12 @@ __metadata:
languageName: node
linkType: hard

"@noble/curves@npm:^1.2.0, @noble/curves@npm:^1.8.1":
version: 1.8.1
resolution: "@noble/curves@npm:1.8.1"
"@noble/curves@npm:^1.2.0, @noble/curves@npm:^1.8.1, @noble/curves@npm:^1.9.2":
version: 1.9.2
resolution: "@noble/curves@npm:1.9.2"
dependencies:
"@noble/hashes": "npm:1.7.1"
checksum: 10/e861db372cc0734b02a4c61c0f5a6688d4a7555edca3d8a9e7c846c9aa103ca52d3c3818e8bc333a1a95b5be7f370ff344668d5d759471b11c2d14c7f24b3984
"@noble/hashes": "npm:1.8.0"
checksum: 10/f60f00ad86296054566b67be08fd659999bb64b692bfbf11dbe3be1f422ad4d826bf5ebb2015ce2e246538eab2b677707e0a46ffa8323a6fae7a9a30ec1fe318
languageName: node
linkType: hard

Expand All @@ -4808,17 +4801,10 @@ __metadata:
languageName: node
linkType: hard

"@noble/hashes@npm:1.7.1":
version: 1.7.1
resolution: "@noble/hashes@npm:1.7.1"
checksum: 10/ca3120da0c3e7881d6a481e9667465cc9ebbee1329124fb0de442e56d63fef9870f8cc96f264ebdb18096e0e36cebc0e6e979a872d545deb0a6fed9353f17e05
languageName: node
linkType: hard

"@noble/hashes@npm:^1.1.2, @noble/hashes@npm:^1.3.1, @noble/hashes@npm:^1.3.2, @noble/hashes@npm:^1.4.0, @noble/hashes@npm:^1.7.1":
version: 1.7.2
resolution: "@noble/hashes@npm:1.7.2"
checksum: 10/b5af9e4b91543dcc46a811b5b2c57bfdeb41728361979a19d6110a743e2cb0459872553f68d3a46326d21959964db2776b8c8b4db85ac1d9f63ebcaddf7d59b6
"@noble/hashes@npm:1.8.0, @noble/hashes@npm:^1.1.2, @noble/hashes@npm:^1.3.1, @noble/hashes@npm:^1.3.2, @noble/hashes@npm:^1.4.0, @noble/hashes@npm:^1.7.1, @noble/hashes@npm:^1.8.0":
version: 1.8.0
resolution: "@noble/hashes@npm:1.8.0"
checksum: 10/474b7f56bc6fb2d5b3a42132561e221b0ea4f91e590f4655312ca13667840896b34195e2b53b7f097ec080a1fdd3b58d902c2a8d0fbdf51d2e238b53808a177e
languageName: node
linkType: hard

Expand Down
Loading