feat: made the lint script actually exit with a fail if eslint found errors

Author: CDeltakai

src/bin/lint.ts

@@ -66,11 +66,15 @@ async function main(argv = process.argv) {
   }
 
   try {
-    await utils.runESLint({
+    const hadLintingErrors = await utils.runESLint({
       fix,
       configPath: chosenConfig,
       explicitGlobs: eslintPatterns,
     });
+
+    if (hadLintingErrors) {
+      hadFailure = true;
+    }
   } catch (err) {
     console.error(`ESLint failed: \n${err}`);
     hadFailure = true;
@@ -182,7 +186,10 @@ async function main(argv = process.argv) {
   }
 
   if (hadFailure) {
+    console.error('[matrixai-lint]  ✖  Linting failed.');
     process.exit(1);
+  } else {
+    console.error('[matrixai-lint]  ✔  Linting passed.');
   }
 }
 

src/utils.ts

@@ -16,7 +16,7 @@ async function runESLint({
   fix: boolean;
   configPath?: string;
   explicitGlobs?: string[];
-}) {
+}): Promise<boolean> {
   const dirname = path.dirname(url.fileURLToPath(import.meta.url));
   const defaultConfigPath = path.resolve(dirname, './configs/js.js');
 
@@ -33,8 +33,7 @@ async function runESLint({
       ignorePatterns: [], // Trust caller entirely
     });
 
-    await lintAndReport(eslint, explicitGlobs, fix);
-    return;
+    return await lintAndReport(eslint, explicitGlobs, fix);
   }
 
   // PATH B – default behaviour (tsconfig + matrix config)
@@ -63,10 +62,14 @@ async function runESLint({
     ignorePatterns: ignorePats,
   });
 
-  await lintAndReport(eslint, patterns, fix);
+  return await lintAndReport(eslint, patterns, fix);
 }
 
-async function lintAndReport(eslint: ESLint, patterns: string[], fix: boolean) {
+async function lintAndReport(
+  eslint: ESLint,
+  patterns: string[],
+  fix: boolean,
+): Promise<boolean> {
   const results = await eslint.lintFiles(patterns);
 
   if (fix) {
@@ -75,6 +78,9 @@ async function lintAndReport(eslint: ESLint, patterns: string[], fix: boolean) {
 
   const formatter = await eslint.loadFormatter('stylish');
   console.log(formatter.format(results));
+  const hasErrors = results.some((r) => r.errorCount > 0);
+
+  return hasErrors;
 }
 /* eslint-enable no-console */