-
Notifications
You must be signed in to change notification settings - Fork 49
Deprecate Python 3.6 support, v0.14 last supported version #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
==========================================
- Coverage 92.79% 92.72% -0.08%
==========================================
Files 68 68
Lines 3663 3668 +5
==========================================
+ Hits 3399 3401 +2
- Misses 264 267 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge after fixing
|
Cheers guys. I'm trying to force it to show. Maybe I should just make it a print statement instead? |
|
Yeah, a |
Indeed. I tried wrapping it in a context where I changed the warnings filter, but I believe it also overwrites the |
|
Through some testing, I've found that it's extremely difficult to get output in stdout/stderr. I think instead I'll put a warning when the module is imported. It should only show once. |
|
The message now shows up once when anything is imported from the |
Since it's not critical to drop Python 3.6 anymore, it's nicer with a grace period. Even though it may be short.
This PR implements a
DeprecationWarningexplaining that v0.14 will be the last version to support Python 3.6, and that one should update to Python 3.7+ to receive v0.15 and onwards.