From b4dc3873b3eef0db7a3ca33ab1ad7906fbcac0c1 Mon Sep 17 00:00:00 2001 From: Daniel Black Date: Mon, 17 Nov 2025 17:56:21 +1100 Subject: [PATCH] MDEV-20022 sql_mode="oracle" TO_NUMBER - fix clang compile Clang(21.5) issues the following warning and suggestion that has been applied: sql/item_numconvfunc.cc:2447:15: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] 2447 | std::move(Zeros_or_nines(static_cast(rhs))), | ^ sql/item_numconvfunc.cc:2447:15: note: remove std::move call here 2447 | std::move(Zeros_or_nines(static_cast(rhs))), | ^~~~~~~~~~ --- sql/item_numconvfunc.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/item_numconvfunc.cc b/sql/item_numconvfunc.cc index 9809149fe45b4..974824e47abb3 100644 --- a/sql/item_numconvfunc.cc +++ b/sql/item_numconvfunc.cc @@ -2444,7 +2444,7 @@ class Parser: public Tokenizer, :A(Unsigned_currency::Container( Approximate::Container( Decimal( - std::move(Zeros_or_nines(static_cast(rhs))), + Zeros_or_nines(static_cast(rhs)), std::move(static_cast(rhs))), std::move(static_cast(rhs))))), B(std::move(static_cast(rhs)))