Skip to content

fix issue#633: web-map looks for viewer in condition #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix issue#633: web-map looks for viewer in condition #905

merged 2 commits into from
Nov 9, 2023

Conversation

@yhy0217
Copy link
Contributor

@yhy0217 yhy0217 commented Nov 9, 2023 •
edited
Loading

Closes #633

@yhy0217 yhy0217 marked this pull request as ready for review November 9, 2023 20:15
@yhy0217 yhy0217 requested review from AliyanH and prushforth November 9, 2023 20:16
@AliyanH AliyanH mentioned this pull request Nov 9, 2023
Open
prushforth
prushforth approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhy0217 yhy0217 merged commit fde273c into Maps4HTML:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prushforth prushforth prushforth approved these changes

@AliyanH AliyanH AliyanH approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<map is="web-map"> looks for <mapml-viewer> in condition

3 participants

@yhy0217 @prushforth @AliyanH