make Paragraph use CairoText #798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some instances, Pango and
Textworks in a weird way due to the fact that it does some things in a rather different way when compared to Cairo andCairoText. The classCodeis one of those that relied on certain behavior ofCairoTextthat changed when switching to Pango -- and has not yet been fixed. In order to have a working version ofCodeagain, this PR makesParagraphuseCairoTextinstead ofTextand thus restores the old behavior.Explanation for Changes
One thing that was changed in particular was how whitespace is counted:
Textcurrently does not add invisible mobjects for spaces, which is why the coloring thatCodeapplies to a given code snippet is off.Testing Status
With this PR,

Code("snippet.py", background="window", font="Roboto Mono")renders as this:Acknowledgement