Follow Up PR from Color enums #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackl
requested changes
Sep 30, 2020
Co-authored-by: Benjamin Hackl <[email protected]>
leotrs
approved these changes
Sep 30, 2020
behackl
approved these changes
Oct 1, 2020
Member
behackl
left a comment
behackl
left a comment
There was a problem hiding this comment.
This looks good to me. With the doctests taking over the test from tests/test_color.py, we could remove the file again. I might have a slight preference for removing it to keep only actually necessary files around, but would also be okay with keeping it around.
behackl
requested changes
Oct 1, 2020
Co-authored-by: Benjamin Hackl <[email protected]>
behackl
approved these changes
Oct 1, 2020
leotrs
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #488