Skip to content

fix #460 by enabling skipping wait statements. #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 29, 2020
Merged

fix #460 by enabling skipping wait statements. #468

merged 4 commits into from
Sep 29, 2020

Conversation

@huguesdevimeux
Copy link
Member

@huguesdevimeux huguesdevimeux commented Sep 22, 2020 •
edited
Loading

List of Changes

  • Now wait can be skipped. It was not the case before; only play statement were skipped when, for example, -n flag was passed.

Explanation for Changes

What I added is pretty much a copy paste of how the skipping is handled in for self.play. It's copied from scene.handle_caching_play

Testing Status

Added tests for play skip and wait skips.

Acknowledgement

closes #460

@huguesdevimeux huguesdevimeux mentioned this pull request Sep 22, 2020
Closed
@cobordism
Copy link
Member

cobordism commented Sep 23, 2020

I can confirm that the issue is solved for me.

behackl
behackl approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have also tested that it resolves #460.

@huguesdevimeux
Copy link
Member Author

huguesdevimeux commented Sep 23, 2020

Very nice. I will add a test and let's merge this

@huguesdevimeux
Copy link
Member Author

huguesdevimeux commented Sep 23, 2020

UPDATE : added tests. Review at will :D

@huguesdevimeux huguesdevimeux marked this pull request as ready for review September 23, 2020 17:02
behackl
behackl approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and LGTM.

@behackl behackl added pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! testing Anything related to testing the library labels Sep 24, 2020
behackl
behackl requested changes Sep 24, 2020
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was a bit too fast: please consider the suggestion regarding the wildcard import and run black.

@huguesdevimeux
Copy link
Member Author

huguesdevimeux commented Sep 24, 2020

Should be good now :D

behackl
behackl approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's good! :-)

@huguesdevimeux huguesdevimeux merged commit 9271ca8 into ManimCommunity:master Sep 29, 2020
@huguesdevimeux huguesdevimeux deleted the fix-460 branch September 29, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behackl behackl behackl approved these changes

@leotrs leotrs Awaiting requested review from leotrs

+1 more reviewer

@kilacoda-old kilacoda-old kilacoda-old approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! testing Anything related to testing the library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error on compiling video: partial_movie_file_list.txt: No such file or directory

4 participants

@huguesdevimeux @cobordism @behackl @kilacoda-old