Fix scene skipping for config.upto_animation_number (-n flag in CLI) set to 0 to end after first animation
#4013
+29
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
chopan050
approved these changes
Nov 13, 2024
Contributor
chopan050
left a comment
chopan050
left a comment
There was a problem hiding this comment.
LGTM! Just tested and everything seems fine!
chopan050
added
the
pr:easy review
chopan050
changed the title
config.upto_animation_number set to 0 to end after first animationconfig.upto_animation_number (-n flag in CLI) set to 0 to end after first animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check against
config.upto_animation_numberchecks whether the value is truthy, when in fact we should check whether it is non-negative.Fixes #4012.