Minor fix, return self #3236
Merged
Minor fix, return self #3236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoiding the creation of an Arc object at import time
This resolves [last comment](ManimCommunity#485 (comment)) of ManimCommunity#485. Removes one line of dead code. Co-authored-by: Benjamin Hackl <[email protected]>
…tion class (ManimCommunity#3229) * Make errors during docbuild somewhat easier to debug * fix an issue with docbuild under py3.10+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Minor fix, added a
return selftoAbstractImageMobject.set_resampling_algorithm()Motivation and Explanation: Why and how do your changes improve the library?
Since the function returned
None, it could not be used in chains of calls. This is not consistent with most of the MObject setting methods.Links to added or changed documentation pages
Further Information and Comments
Change triggered by a question in the Discord community: https://discord.com/channels/581738731934056449/1105958826852753418/1105965772691484713
Reviewer Checklist