Added the option to save last frame for OpenGL #1952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4pran
force-pushed
the
opengl-save-last-frame
branch
2 times, most recently
from
6f56045 to
64300b8
Compare
Member
|
Works for me on Windows, not really sure why the tests are failing? |
k4pran
force-pushed
the
opengl-save-last-frame
branch
from
64300b8 to
e69c14b
Compare
Collaborator
Author
Yea I am not sure, but as discussed I removed the test for now |
Darylgolden
approved these changes
Aug 25, 2021
Member
Darylgolden
left a comment
Darylgolden
left a comment
There was a problem hiding this comment.
LGTM, let's wait on opinions from more devs to see if they're ok with omitting the test.
hydrobeam
approved these changes
Aug 26, 2021
Member
hydrobeam
left a comment
hydrobeam
left a comment
There was a problem hiding this comment.
Looks good to me and works as expected, just left a question about the method.
Darylgolden
changed the title
k4pran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
#1936
Implement option to save last frame as an image for opengl
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist