Skip to content

Add 4K option #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2020
Merged

Add 4K option #16

merged 3 commits into from
May 19, 2020

Conversation

@safinsingh
Copy link
Contributor

@safinsingh safinsingh commented May 19, 2020

Add a 4K option for those who want to render at a high quality.

@safinsingh
Copy link
Contributor Author

safinsingh commented May 19, 2020

It uses --four_k

@XorUnison
Copy link
Collaborator

XorUnison commented May 19, 2020 •
edited
Loading

I'd still replace --four_k with just -k. --four_k is longer than -r 4K and also breaks with the convention of other single character resolution definitions like -l and -m

XorUnison
XorUnison requested changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@XorUnison XorUnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of switching --four_k with just -k.

@PgBiel PgBiel self-requested a review May 19, 2020 21:07
@safinsingh safinsingh merged commit 154db7f into master May 19, 2020
PgBiel
PgBiel reviewed May 20, 2020
View reviewed changes
Copy link
Member

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@safinsingh safinsingh deleted the add-fourk-option branch May 20, 2020 04:57
@PgBiel PgBiel added enhancement Additions and improvements in general new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) labels May 20, 2020
@leotrs leotrs mentioned this pull request May 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PgBiel PgBiel PgBiel left review comments

@XorUnison XorUnison XorUnison approved these changes

Assignees

No one assigned

Labels

enhancement Additions and improvements in general new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@safinsingh @XorUnison @PgBiel