-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Closed
Labels
pr:deprecationDeprecation, or removal of deprecated codeDeprecation, or removal of deprecated coderefactorRefactor or redesign of existing codeRefactor or redesign of existing code
Description
Now, _run_config returns that :
manim/manim/config/config_utils.py
Line 536 in 1a516db
| return args, config_parser, file_writer_config, successfully_read_files |
4 things, including file_writer_config.
I do think file_writer_config should be computed outside this function, as now there are several others config type (in particular cfg subcommand, logger, and later livestream subcommand).
file_writer_config should use config_parser like the other configs, outside of _run_config()
Cc @leotrs
Metadata
Metadata
Assignees
Labels
pr:deprecationDeprecation, or removal of deprecated codeDeprecation, or removal of deprecated coderefactorRefactor or redesign of existing codeRefactor or redesign of existing code