remove animation.update

[huguesdevimeux]

Bsically the title. this method is useless. See the code and the comment :

manim/manim/animation/animation.py

Lines 115 to 120 in 5dd7bfe

	def update(self, alpha):
	"""
	This method shouldn't exist, but it's here to
	keep many old scenes from breaking
	"""
	self.interpolate(alpha)

[leotrs]

We should add a deprecation warning

[musabkilic]

I think adding a warning for a while to give people some time to update is a better idea, similar to:

manim/manim/mobject/svg/tex_mobject.py

Lines 334 to 349 in 97de346

	class TexMobject(MathTex):
	def __init__(self, *tex_strings, **kwargs):
	logger.warning(
	"TexMobject has been deprecated (due to its confusing name) "
	"in favour of MathTex. Please use MathTex instead!"
	)
	MathTex.__init__(self, *tex_strings, **kwargs)
	class TextMobject(Tex):
	def __init__(self, *text_parts, **kwargs):
	logger.warning(
	"TextMobject has been deprecated (due to its confusing name) "
	"in favour of Tex. Please use Tex instead!"
	)
	Tex.__init__(self, *text_parts, **kwargs)

[huguesdevimeux]

I think adding a warning for a while to give people some time to update is a better idea, similar to:

Yes (that's basically what @leotrs said lol)

[musabkilic]

I can add one with:

"animation.update(alpha) has been deprecated (due to its confusing name) "
"in favour of animation.interpolate(alpha). Please use interpolate() instead!"
let me know if it sounds good.

[leotrs]

"animation.update() has been deprecated. Please use animation.interpolate() instead."

Fewer words, same meaning.

[meanmachin3]

Can I take this up ?

[leotrs]

Yes, thanks!

[musabkilic]

Sorry, I didn't see @meanmachin3 comment. Should I sent a pull request anyway?