Fix custom share server functionality #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps2
pushed a commit
that referenced
this pull request
Aug 6, 2020
marionbarker
added a commit
to loopnlearn/dexcom-share-client-swift
that referenced
this pull request
Feb 27, 2022
* Add languages (cherry picked from commit 269de43fd02c7f4496fc391ee7ee779aa29c5fc2) * Add file (cherry picked from commit a93636c88fde349ae40295e5d24eacaf8b5c5e2a) * Update Crowdin configuration file * Update Crowdin configuration file * Update Crowdin configuration file * Create .gitattributes * Update .gitattributes * Update .gitattributes * Create .gitconfig * Delete .gitconfig * trying to fix encoding * Crowdin (LoopKit#9) * Delete .gitattributes * Watch Loop Scene adjustments (cherry picked from commit eef849bf4e4cc4e308bf69f54e734255b6a32541) * Norwegian Bokmal * Watch Loop Scene adjustments Changed back encoding in Xcode settings. (cherry picked from commit eef849bf4e4cc4e308bf69f54e734255b6a32541) * Norwegian Bokmal * hotfix: dexcom share encode Trend as string * hotfix: more elegant solution for dexcom share encode Trend as string * Russian Co-authored-by: marionbarker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although tried and implemented before, the current implementation does not have a working solution to enable the use of a custom share server for Dexcom share.
I fixed this and added support for a custom share server. The user has to uncomment 3 lines in 2 different files and add his custom share server URL. The option "Custom" will appear in the Dexcom Share server selection in Loop.
This is needed for CGMs that cannot be directly connected via the phone and need data to be retrieved from Nightscout by using a share server that supports Nightscout (https://github.com/dabear/NightscoutShareServer).