From be77254fc89bdbc7fdaf410db24a0648b1d8d200 Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Sun, 1 Sep 2019 15:25:53 -0500 Subject: [PATCH 1/4] Use xcode11 branch --- Cartfile | 2 +- Cartfile.resolved | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cartfile b/Cartfile index 05195c5..5d9e6bc 100644 --- a/Cartfile +++ b/Cartfile @@ -1 +1 @@ -github "LoopKit/LoopKit" "dev" +github "LoopKit/LoopKit" "xcode11" diff --git a/Cartfile.resolved b/Cartfile.resolved index f6a15b9..07ccad3 100644 --- a/Cartfile.resolved +++ b/Cartfile.resolved @@ -1 +1 @@ -github "LoopKit/LoopKit" "c8c4810de7171ecedc3f1eb003f3cb77bdd76015" +github "LoopKit/LoopKit" "6142c0cf955b5b44f5e90b245ad3037b2936f424" From ce8f58f2f79778365acd828b007b8a5e86772844 Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Sun, 1 Sep 2019 15:35:44 -0500 Subject: [PATCH 2/4] Travis use xcode11 --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index c044b08..c6df942 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,9 +1,9 @@ language: objective-c -osx_image: xcode10.2 +osx_image: xcode11 before_script: - carthage bootstrap script: # Build Travis project and run tests - - xcodebuild -project ShareClient.xcodeproj -scheme Shared build -destination name="iPhone SE" test + - xcodebuild -project ShareClient.xcodeproj -scheme Shared build -destination name="iPhone 6" test From e94c98b63c64b110ff38d404992c93c9d5a03bbc Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Fri, 13 Sep 2019 15:43:10 -0500 Subject: [PATCH 3/4] Separate bundle ids by platform to fix App Store Connect error --- ShareClient/Info.plist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShareClient/Info.plist b/ShareClient/Info.plist index a6f720e..ee98428 100644 --- a/ShareClient/Info.plist +++ b/ShareClient/Info.plist @@ -7,7 +7,7 @@ CFBundleExecutable $(EXECUTABLE_NAME) CFBundleIdentifier - $(PRODUCT_BUNDLE_IDENTIFIER) + $(PRODUCT_BUNDLE_IDENTIFIER)-$(PLATFORM_NAME) CFBundleInfoDictionaryVersion 6.0 CFBundleName From 561b1b7c226a168d61841e52eb64649090060d53 Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Fri, 13 Sep 2019 17:20:39 -0500 Subject: [PATCH 4/4] Bump carthage revs --- Cartfile | 2 +- Cartfile.resolved | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cartfile b/Cartfile index 5d9e6bc..05195c5 100644 --- a/Cartfile +++ b/Cartfile @@ -1 +1 @@ -github "LoopKit/LoopKit" "xcode11" +github "LoopKit/LoopKit" "dev" diff --git a/Cartfile.resolved b/Cartfile.resolved index 07ccad3..34cb669 100644 --- a/Cartfile.resolved +++ b/Cartfile.resolved @@ -1 +1 @@ -github "LoopKit/LoopKit" "6142c0cf955b5b44f5e90b245ad3037b2936f424" +github "LoopKit/LoopKit" "18a5a04afd310e945ac54f8c43a44838a16503c2"