Show the glucose chart in the widget #377

bharat · 2017-02-12T02:01:04Z

Updates

3/21/2017

added new screenshots
working on new to-do items at the bottom of this description.

3/23/2017

added higher res screenshots

Details

This is the basic framework for exposing the glucose history and the predicted glucose in the widget. This takes advantage of the widget display modes that lets you zoom open the widget and show more details.

compact form looks like normal, but note that there's a [show more] link in the top right:

expanded form looks like this:

Work completed:

show the target BG range
move the chart code into the LoopUI framework
update screenshot to show latest layout
tighten up prediction values to be start date, interval and array of doubles.
reduce historical glucose data to 30 minutes so that we have a consistent experience regardless of whether the last data update came in when the device was locked or unlocked
Don't store new property in StatusChartsManager extensions - use a protocol or delegate in the common class and inject appropriate object from view controllers in Loop and extension
only serialize the most recent SensorDisplayableContext since that's the only thing we show in the extension UI
don't hardcode chart end date in the widget, use the last prediction value -- punt this for now
get rid of eventual glucose and use the last prediction value

lot of UI polish. Using fake data.

elnjensen · 2017-02-13T21:07:52Z

Looks great! What sets the amount of time displayed on the x axis?

If the show more / show less is toggled once, will it stay that way next time you display? Or will you have to open it each time? The former seems preferable to me if it's possible.

Also, I'll put in another plug for displaying IOB ("Active insulin") in the status widget if possible. Separate issue, I know, but it would be useful to see it there.

ps2 · 2017-02-26T01:46:08Z

@bharat Let me know when you think this is ready for review.

bharat · 2017-02-26T20:38:14Z

It's worth a review just to make sure I'm headed in the right direction - but I haven't had much time to dig into this recently so I haven't advanced the ball beyond the initial commit...

…ation in LoopUI

bharat · 2017-03-13T23:21:56Z

ok. I've cleaned up most of the major issues and synced this up with the latest changes in dev. We're down to two extension unsafe dylib warnings, and I still need to work on the BG range code - but it's headed in the right direction. As far as I can tell. Feel free to lob in criticism!

…atus Extension into Common

elnjensen · 2017-03-19T16:19:04Z

Following this with interest - let me know if you need any testing of anything. Thanks for your work on this.

SwiftCharts in my own fork. The master branch doesn't compile and I want to make the smallest possible change to bring this in line.

bharat · 2017-03-21T07:23:31Z

ok - this is now functionally complete and doesn't generate any warnings.. yay! I need to do a pass over it just to make sure there isn't anything dumb in there and then it'll be ready for a real review.

Now it's a start date, an interval, and a series of double values.

Add a TargetPointsCalculator to StatusChartsManager which Loop and Loop Status Extension can each implement separately.

Also, fix a bug where target ranges should get completely recalculated when you delete one of them.

bharat · 2017-03-23T15:10:37Z

@ps2 - not sure why the Travis builds are failing. I can't repro the failure in my dev environment and I don't see clues in the Travis output. :-/

sarahspins · 2017-03-23T16:06:32Z

I know it's been requested before, but any chance to add a tiny IOB chart as well?

bharat · 2017-03-23T16:09:18Z

@sarahspins that's a good idea (and I know that others want it as well). would you please file a separate feature request for that? I'd like to do it separately since I'm trying to avoid growing the scope of this pull request.

sarahspins · 2017-03-23T16:11:25Z

Will do :)

bharat · 2017-03-27T17:06:16Z

@ps2 - I think this is good to go!

@bharat

* refactor of CGM device management * Adding missing files from last cgm refactor pr * Fail if any command in pipeline fails * handling a memory warning and tweaks to the diagnostic report * Fix tests that had been breaking for a while but were hidden by xcpretty swallowing exit code * Show the glucose chart in the widget (#377) Show the glucose chart in the widget. Thanks @bharat! * Swift 3.1 - rebuild all frameworks, clean up all swift warnings (#421) * Rebuild all frameworks with swift 3.1 * Resolve all Swift 3.1 warnings * Swift 3.1 - update LoopKit to 1.2.1 (#423) update LoopKit to 1.2.1 * Swift 3.1 - post widget merge cleanups (#424) * Extend ChartColorPalette in Loop target to add a .default() palette * Update chart appropriately when we remove glucose targets * Drop the first predicted glucose entry. It's the current glucose and its interval to the second is not uniform with the interval for the rest * Use predictedGlucose.startIndex for clarity instead of hardcoding indexes * Swift 3.1 - update dexcom-share-client-swift and G4ShareSpy frameworks (#422) update dexcom-share-client-swift and G4ShareSpy frameworks * Project and margin cleanups (#427) * support share-only cgm source (#426) * fall back to getting cgm data from share if no others are configured * use absence of g5 transmitter to indicate share-only setup. * Widget should always display data using the preferred dispay unit, (#434) regardless of the units used in the StatusExtensionContext. * Break the tie between two visual constraints. (#439) "<NSLayoutConstraint:0x600000097430 LoopUI.ChartContentView:0x7f808c50aae0.height >= 100 (active)>", "<NSLayoutConstraint:0x60000009c2f0 'UISV-hiding' LoopUI.ChartContentView:0x7f808c50aae0.height == 0 (active)>" Lower the priority of the height >= 100 constraint. * bump version (#441)

* using lifecycle progress state dimmed to color bar * using lifecycle progress state dimmed to color bar

Bharat Mediratta added 8 commits January 8, 2017 17:30

WIP

4104b1f

Show the glucose chart, support accordioning open/closed. Still needs a

3142e82

lot of UI polish. Using fake data.

WIP

88ee761

WIP

65a3cd3

Merge branch 'dev' into dev-show-more

3e76861

WIP

4b618d0

WIP

2a54839

WIP

7c5df77

WIP

428304b

Bharat Mediratta added 13 commits March 4, 2017 14:52

Merge branch 'dev' into dev-show-more

2454471

Move ChartContentView into LoopUI

8b2a238

Merge branch 'dev' into dev-show-more

f94ef85

post merge cleanup

51f5eb1

WIP

7bfdef5

WIP

e82407f

WIP

bdcf83f

Make chart background clear and use appropriate colors

da99ffb

Merge branch 'dev' into dev-show-more

7ea1d07

Fix predicted glucose scene to use ChartContentView from it's new loc…

3e0261c

…ation in LoopUI

animate alpha of chart in/out as we show more/less

88282a4

Set the start date for the extension chart more sensibly

c1e95f4

Minor cleanups

f22767a

Bharat Mediratta added 4 commits March 15, 2017 09:05

Store glucose target range in the status extension context

5b7e75c

checkpoint

c75f9ce

Break StatusChartsManager's dependency on LoopKit.

181185d

Move Chart views, models and extensions used by both Loop and Loop St…

d69b8bb

…atus Extension into Common

Bharat Mediratta added 2 commits March 16, 2017 23:51

Break charting code's dependency on LoopKit

c9a1496

Update to SwiftCharts 0.5.1 which should be app extension safe

8feea50

Bharat Mediratta added 2 commits March 20, 2017 21:19

Apply APPLICATION_EXTENSION_API_ONLY=YES on top of the 0.5.1 branch of

4f0755f

SwiftCharts in my own fork. The master branch doesn't compile and I want to make the smallest possible change to bring this in line.

Merge branch 'dev' into dev-show-more

f888758

Bharat Mediratta added 8 commits March 21, 2017 12:00

Only show the last 30 minutes of glucose data

eca3e2d

Only serialize the most recent SensorDisplayable

2571a78

Encode predicted glucose in a tighter form

7c032d8

Now it's a start date, an interval, and a series of double values.

Combine the two StatusChartsManager extensions in Loop

9b74b6c

Stop using stored properties in extensions.

98a49da

Add a TargetPointsCalculator to StatusChartsManager which Loop and Loop Status Extension can each implement separately.

Don't recalculate target range points on every prerender()

c0c48ef

Also, fix a bug where target ranges should get completely recalculated when you delete one of them.

Set the test predicted glucose data duration to 3 hours

246267a

Peg the chart end date to the last predicted glucose value

a917be1

sarahspins mentioned this pull request Mar 23, 2017

Add a tiny IOB chart to Widget? #415

Closed

Fix name of file in header comment

d732fb3

ps2 merged commit 1885f09 into LoopKit:dev Mar 29, 2017

ps2 pushed a commit that referenced this pull request Mar 26, 2021

[LOOP-3122] Dimmed device lifecycle progress (#377)

f90d2fd

* using lifecycle progress state dimmed to color bar * using lifecycle progress state dimmed to color bar

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Show the glucose chart in the widget #377

Show the glucose chart in the widget #377

Uh oh!

bharat commented Feb 12, 2017 •

edited

Loading

Uh oh!

elnjensen commented Feb 13, 2017

Uh oh!

ps2 commented Feb 26, 2017

Uh oh!

bharat commented Feb 26, 2017

Uh oh!

bharat commented Mar 13, 2017

Uh oh!

elnjensen commented Mar 19, 2017

Uh oh!

bharat commented Mar 21, 2017

Uh oh!

bharat commented Mar 23, 2017

Uh oh!

sarahspins commented Mar 23, 2017

Uh oh!

bharat commented Mar 23, 2017

Uh oh!

sarahspins commented Mar 23, 2017

Uh oh!

bharat commented Mar 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Show the glucose chart in the widget #377

Show the glucose chart in the widget #377

Uh oh!

Conversation

bharat commented Feb 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updates

3/21/2017

3/23/2017

Details

Uh oh!

elnjensen commented Feb 13, 2017

Uh oh!

ps2 commented Feb 26, 2017

Uh oh!

bharat commented Feb 26, 2017

Uh oh!

bharat commented Mar 13, 2017

Uh oh!

elnjensen commented Mar 19, 2017

Uh oh!

bharat commented Mar 21, 2017

Uh oh!

bharat commented Mar 23, 2017

Uh oh!

sarahspins commented Mar 23, 2017

Uh oh!

bharat commented Mar 23, 2017

Uh oh!

sarahspins commented Mar 23, 2017

Uh oh!

bharat commented Mar 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bharat commented Feb 12, 2017 •

edited

Loading