Refactor files with membership in multiple targets into a Common hierarchy #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
December 11, 2016 16:27
… that it doesn't have to pull in HUDViewKit
1. Make HKUnit extension internal and included it directly into all necessary targets to avoid a conflict with the same extension in LoopKit 2. Publicize any necessary HUDViewKit vars, funcs 3. Store the Int raw value for GlucoseTrend in WatchContext and create a computed property that returns it as a GlucoseTrend object to avoid the conflict where both Loop and WatchApp Extension have their own separate concept of GlucoseTrend.
Author
|
ok - this is now ready for a look. |
loudnate
approved these changes
Jan 2, 2017
ps2
pushed a commit
that referenced
this pull request
Mar 17, 2021
…ix TestFlight uploads (#352) Uploads to ASC (TestFlight) are failing. See https://developer.apple.com/forums/thread/671352 Hopefully this is a temporary workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is stacked up behind #330 so the diff is going to be wonky until that is merged into dev. Basically all I'm doing is
git mvon every file into a new hierarchy and then fixing up the location in Xcode. There are no code changes.