Better fix for #159 #199
Merged
Better fix for #159 #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #130 Better use of space on iPhone SE and iPhone 7 Plus
ps2
pushed a commit
that referenced
this pull request
Aug 27, 2020
* LOOP-1160: "scroll" to Bolus Entry when Enter Bolus is tapped This ugly hack is due to the fact that SwiftUI cannot _yet_ programmatically scroll. Still needs Design to approve the behavior. * Comment change * More design feedback: - Ensure the "Active Carbs" and Active Insulin" label shows with zeros if no data is available - Ensure the primary button switches if is bolus is ready for deliver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130
Better use of space on iPhone SE and iPhone 7 Plus