Display of mmol/L units

[beached]

It looks like Loop is trying to display too many digits for mmol/L. Only 3 are ever needed at most. Actually , when the pump reports a bg <=99mg/dl only 2 are needed( so <=5.5mmol/L) but for consistency 3 is usually fine.

As one can see, this causes formatting bugs

Seeing as the data from the pump expresses the info in mg/dl and generally has 3 significant digits this could be accomplished with a formatting flag of %.1f

[beached]

I am testing the use of

numberFormatter.usesSignificantDigits = true
numberFormatter.minimumSignificantDigits = 2
numberFormatter.maximumSignificantDigits = 3

To format the glucose hud display.

[loudnate]

Thanks – the NSNumberFormatter significant digits setting is exactly how I planned to fix these cases.

The screenshots are really helpful. Please add any more where things aren't correct to this ticket!

[beached]

I was thinking that maybe, excuse my swift, but a member of the HKUnit that formats blood glocose or a subtype of sorts that does it. then any string for a glucose uses that.

[loudnate]

Yeah, that's what's existed here: https://github.com/loudnate/LoopKit/blob/master/LoopKit/HKUnit.swift#L21-L28

[beached]

So that fixed the issue in issue in the glucosehud. Not the graphs or other areas.

[beached]

Looks like the retrospective correction screen is hardwired to mg/dl

[beached]

Actually, I am wrong, it does eventually but the scale is off

[beached]

The units updated after checking/unchecking