[COASTAL-102] Set-max-bolus-limit

* support syncing delivery limits

* response to PR comments

Author: nhamming

Loop/View Controllers/StatusTableViewController.swift

@@ -1394,6 +1394,9 @@ final class StatusTableViewController: LoopChartsTableViewController {
         let syncBasalRateSchedule = { [weak self] in
             self?.deviceManager.pumpManager?.syncBasalRateSchedule
         }
+        let syncDeliveryLimits = { [weak self]  in
+            self?.deviceManager.pumpManager?.syncDeliveryLimits
+        }
         let servicesViewModel = ServicesViewModel(showServices: FeatureFlags.includeServicesInSettingsEnabled,
                                                   availableServices: { [weak self] in self?.deviceManager.servicesManager.availableServices ?? [] },
                                                   activeServices: { [weak self] in self?.deviceManager.servicesManager.activeServices ?? [] },
@@ -1406,6 +1409,7 @@ final class StatusTableViewController: LoopChartsTableViewController {
                                           therapySettings: { [weak self] in self?.deviceManager.loopManager.therapySettings ?? TherapySettings() },
                                           pumpSupportedIncrements: pumpSupportedIncrements,
                                           syncPumpSchedule: syncBasalRateSchedule,
+                                          syncDeliveryLimits: syncDeliveryLimits,
                                           sensitivityOverridesEnabled: FeatureFlags.sensitivityOverridesEnabled,
                                           initialDosingEnabled: deviceManager.loopManager.settings.dosingEnabled,
                                           isClosedLoopAllowed: closedLoopStatus.$isClosedLoopAllowed,

Loop/View Models/SettingsViewModel.swift

@@ -80,8 +80,10 @@ public class SettingsViewModel: ObservableObject {
     let servicesViewModel: ServicesViewModel
     let criticalEventLogExportViewModel: CriticalEventLogExportViewModel
     let therapySettings: () -> TherapySettings
+    // TODO This pattern of taking a closure that returns a closure is redundant; we should simplify here.
     let pumpSupportedIncrements: (() -> PumpSupportedIncrements?)?
-    let syncPumpSchedule: (() -> PumpManager.SyncSchedule?)?
+    let syncPumpSchedule: (() -> SyncSchedule?)?
+    let syncDeliveryLimits: (() -> SyncDeliveryLimits?)?
     let sensitivityOverridesEnabled: Bool
     let supportInfoProvider: SupportInfoProvider
     let isOnboardingComplete: Bool
@@ -108,7 +110,8 @@ public class SettingsViewModel: ObservableObject {
                 criticalEventLogExportViewModel: CriticalEventLogExportViewModel,
                 therapySettings: @escaping () -> TherapySettings,
                 pumpSupportedIncrements: (() -> PumpSupportedIncrements?)?,
-                syncPumpSchedule: (() -> PumpManager.SyncSchedule?)?,
+                syncPumpSchedule: (() -> SyncSchedule?)?,
+                syncDeliveryLimits: (() -> SyncDeliveryLimits?)?,
                 sensitivityOverridesEnabled: Bool,
                 initialDosingEnabled: Bool,
                 isClosedLoopAllowed: Published<Bool>.Publisher,
@@ -126,6 +129,7 @@ public class SettingsViewModel: ObservableObject {
         self.therapySettings = therapySettings
         self.pumpSupportedIncrements = pumpSupportedIncrements
         self.syncPumpSchedule = syncPumpSchedule
+        self.syncDeliveryLimits = syncDeliveryLimits
         self.sensitivityOverridesEnabled = sensitivityOverridesEnabled
         self.closedLoopPreference = initialDosingEnabled
         self.isClosedLoopAllowed = false

Loop/Views/SettingsView.swift

@@ -135,6 +135,7 @@ extension SettingsView {
                                         viewModel: TherapySettingsViewModel(therapySettings: self.viewModel.therapySettings(),
                                                                             pumpSupportedIncrements: self.viewModel.pumpSupportedIncrements,
                                                                             syncPumpSchedule: self.viewModel.syncPumpSchedule,
+                                                                            syncDeliveryLimits: self.viewModel.syncDeliveryLimits,
                                                                             sensitivityOverridesEnabled: FeatureFlags.sensitivityOverridesEnabled,
                                                                             didSave: self.viewModel.didSave))
                         .environmentObject(displayGlucoseUnitObservable)
@@ -416,6 +417,7 @@ public struct SettingsView_Previews: PreviewProvider {
                                           therapySettings: { TherapySettings() },
                                           pumpSupportedIncrements: nil,
                                           syncPumpSchedule: nil,
+                                          syncDeliveryLimits: nil,
                                           sensitivityOverridesEnabled: false,
                                           initialDosingEnabled: true,
                                           isClosedLoopAllowed: fakeClosedLoopAllowedPublisher.$mockIsClosedLoopAllowed,

LoopTests/Managers/DoseEnactorTests.swift

@@ -24,6 +24,7 @@ extension MockPumpManagerError: LocalizedError {
 class MockPumpManager: PumpManager {
 
     var enactBolusCalled: ((Double, Bool) -> Void)?
+
     var enactTempBasalCalled: ((Double, TimeInterval) -> Void)?
 
     var enactTempBasalError: PumpManagerError?
@@ -105,7 +106,11 @@ class MockPumpManager: PumpManager {
 
     func syncBasalRateSchedule(items scheduleItems: [RepeatingScheduleValue<Double>], completion: @escaping (Result<BasalRateSchedule, Error>) -> Void) {
     }
-    
+
+    func syncDeliveryLimits(limits deliveryLimits: DeliveryLimits, completion: @escaping (Result<DeliveryLimits, Error>) -> Void) {
+
+    }
+
     var managerIdentifier: String = "MockPumpManager"
 
     var localizedTitle: String = "MockPumpManager"