Skip to content

Commit acf9cfa

Browse files
authored
[LOOP-3477] display nothing for trend icon instead of a question mark icon (#391)
1 parent bd86707 commit acf9cfa

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

LoopTests/ViewModels/CGMStatusHUDViewModelTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ class CGMStatusHUDViewModelTests: XCTestCase {
130130
wasUserEntered: true,
131131
isDisplayOnly: false)
132132

133-
XCTAssertEqual(viewModel.manualGlucoseTrendIconOverride, UIImage(systemName: "questionmark.circle"))
133+
XCTAssertNil(viewModel.manualGlucoseTrendIconOverride)
134134
XCTAssertNil(viewModel.statusHighlight)
135135
XCTAssertEqual(viewModel.glucoseValueString, "90")
136136
XCTAssertNil(viewModel.trend)

LoopUI/ViewModel/CGMStatusHUDViewModel.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class CGMStatusHUDViewModel {
2727

2828
var glucoseTrendIcon: UIImage? {
2929
guard let manualGlucoseTrendIconOverride = manualGlucoseTrendIconOverride else {
30-
return trend?.image ?? UIImage(systemName: "questionmark.circle")
30+
return trend?.image
3131
}
3232
return manualGlucoseTrendIconOverride
3333
}
@@ -163,7 +163,7 @@ public class CGMStatusHUDViewModel {
163163
}
164164

165165
func setManualGlucoseTrendIconOverride() {
166-
manualGlucoseTrendIconOverride = storedStatusHighlight?.image ?? UIImage(systemName: "questionmark.circle")
166+
manualGlucoseTrendIconOverride = storedStatusHighlight?.image
167167
glucoseTrendTintColor = storedStatusHighlight?.state.color ?? .glucoseTintColor
168168
}
169169
}

LoopUI/Views/GlucoseTrendHUDView.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ public final class GlucoseTrendHUDView: BaseHUDView {
1919

2020
@IBOutlet private weak var trendIcon: UIImageView! {
2121
didSet {
22-
trendIcon.image = UIImage(systemName: "questionmark.circle")
2322
trendIcon.tintColor = .glucoseTintColor
2423
}
2524
}
@@ -31,6 +30,6 @@ public final class GlucoseTrendHUDView: BaseHUDView {
3130
}
3231

3332
public func setIcon(_ icon: UIImage?) {
34-
trendIcon.image = icon ?? UIImage(systemName: "questionmark.circle")
33+
trendIcon.image = icon
3534
}
3635
}

0 commit comments

Comments
 (0)