Track changing units in charts (#749)

Author: ps2

Loop/View Controllers/CarbAbsorptionViewController.swift

@@ -90,6 +90,10 @@ final class CarbAbsorptionViewController: ChartsTableViewController, Identifiabl
 
     // MARK: - Data loading
 
+    override func glucoseUnitDidChange() {
+        refreshContext = RefreshContext.all
+    }
+
     override func reloadData(animated: Bool = false) {
         guard active && !reloading && !self.refreshContext.isEmpty else { return }
         var currentContext = self.refreshContext

Loop/View Controllers/ChartsTableViewController.swift

@@ -80,6 +80,10 @@ class ChartsTableViewController: UITableViewController, UIGestureRecognizerDeleg
     override func viewDidLoad() {
         super.viewDidLoad()
 
+        if let unit = self.deviceManager.loopManager.glucoseStore.preferredUnit {
+            self.charts.glucoseUnit = unit
+        }
+
         let notificationCenter = NotificationCenter.default
         notificationObservers += [
             notificationCenter.addObserver(forName: .UIApplicationWillResignActive, object: UIApplication.shared, queue: .main) { [weak self] _ in
@@ -138,17 +142,26 @@ class ChartsTableViewController: UITableViewController, UIGestureRecognizerDeleg
         }
     }
 
-    @objc func unitPreferencesDidChange(_ note: Notification) {
+    @objc private func unitPreferencesDidChange(_ note: Notification) {
         DispatchQueue.main.async {
             if let unit = self.deviceManager.loopManager.glucoseStore.preferredUnit {
+                let didChange = unit != self.charts.glucoseUnit
                 self.charts.glucoseUnit = unit
+
+                if didChange {
+                    self.glucoseUnitDidChange()
+                }
             }
             self.log.debug("[reloadData] for HealthKit unit preference change")
             self.reloadData()
         }
     }
 
-    var charts = StatusChartsManager(colors: .default, settings: .default)
+    func glucoseUnitDidChange() {
+        // To override.
+    }
+
+    let charts = StatusChartsManager(colors: .default, settings: .default)
 
     // References to registered notification center observers
     var notificationObservers: [Any] = []

Loop/View Controllers/InsulinModelSettingsViewController.swift

@@ -47,6 +47,10 @@ class InsulinModelSettingsViewController: ChartsTableViewController, Identifiabl
         }
     }
 
+    override func glucoseUnitDidChange() {
+        refreshContext = true
+    }
+
     /// The sensitivity (in glucose units) to use for demonstrating the model
     var insulinSensitivitySchedule = InsulinSensitivitySchedule(unit: .milligramsPerDeciliter, dailyItems: [RepeatingScheduleValue<Double>(startTime: 0, value: 40)])!
 

Loop/View Controllers/PredictionTableViewController.swift

@@ -84,6 +84,10 @@ class PredictionTableViewController: ChartsTableViewController, IdentifiableClas
         }
     }
 
+    override func glucoseUnitDidChange() {
+        refreshContext = RefreshContext.all
+    }
+
     override func reloadData(animated: Bool = false) {
         guard active && visible && !refreshContext.isEmpty else { return }
 

Loop/View Controllers/SettingsTableViewController.swift

@@ -127,15 +127,13 @@ final class SettingsTableViewController: UITableViewController, DailyValueSchedu
     override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
         switch segue.destination {
         case let vc as InsulinModelSettingsViewController:
+            vc.deviceManager = dataManager
             vc.insulinModel = dataManager.loopManager.insulinModelSettings?.model
 
             if let insulinSensitivitySchedule = dataManager.loopManager.insulinSensitivitySchedule {
                 vc.insulinSensitivitySchedule = insulinSensitivitySchedule
             }
 
-            if let unit = dataManager.loopManager.glucoseStore.preferredUnit {
-                vc.glucoseUnit = unit
-            }
             vc.delegate = self
         default:
             break

Loop/View Controllers/StatusTableViewController.swift

@@ -100,7 +100,7 @@ final class StatusTableViewController: ChartsTableViewController {
         }
     }
 
-    var appearedOnce = false
+    private var appearedOnce = false
 
     override func viewWillAppear(_ animated: Bool) {
         super.viewWillAppear(animated)
@@ -183,6 +183,10 @@ final class StatusTableViewController: ChartsTableViewController {
         return !landscapeMode && statusRowMode.hasRow
     }
 
+    override func glucoseUnitDidChange() {
+        refreshContext = RefreshContext.all
+    }
+
     private func updateChartDateRange() {
         let settings = deviceManager.loopManager.settings