Skip to content

Commit 4e7f731

Browse files
authored
COASTAL-625: Relax requirement that HUDProvider needs to provide LevelHUDView (#503)
LevelHUDView is for providing a view that displays a thermometer level, which not all Pumps may provide (e.g. Coastal). This relaxes the requirement and just requires returning a BaseHUDView. https://tidepool.atlassian.net/browse/COASTAL-625
1 parent 5907472 commit 4e7f731

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

Common/Models/PumpManagerUI.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import LoopKitUI
1212

1313
typealias PumpManagerHUDViewRawValue = [String: Any]
1414

15-
func PumpManagerHUDViewFromRawValue(_ rawValue: PumpManagerHUDViewRawValue, pluginManager: PluginManager) -> LevelHUDView? {
15+
func PumpManagerHUDViewFromRawValue(_ rawValue: PumpManagerHUDViewRawValue, pluginManager: PluginManager) -> BaseHUDView? {
1616
guard
1717
let identifier = rawValue["managerIdentifier"] as? String,
1818
let rawState = rawValue["hudProviderView"] as? HUDProvider.HUDViewRawState,

Loop Status Extension/StatusViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ class StatusViewController: UIViewController, NCWidgetProviding {
223223
}
224224

225225
// Pump Status
226-
let pumpManagerHUDView: LevelHUDView
226+
let pumpManagerHUDView: BaseHUDView
227227
if let hudViewContext = context.pumpManagerHUDViewContext,
228228
let contextHUDView = PumpManagerHUDViewFromRawValue(hudViewContext.pumpManagerHUDViewRawValue, pluginManager: self.pluginManager)
229229
{

Loop/View Controllers/StatusTableViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1509,7 +1509,7 @@ final class StatusTableViewController: LoopChartsTableViewController {
15091509
}
15101510
}
15111511

1512-
private func addPumpManagerViewToHUD(_ view: LevelHUDView) {
1512+
private func addPumpManagerViewToHUD(_ view: BaseHUDView) {
15131513
if let hudView = hudView {
15141514
view.stateColors = .pumpStatus
15151515
hudView.addPumpManagerProvidedHUDView(view)

LoopUI/Views/PumpStatusHUDView.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public final class PumpStatusHUDView: DeviceStatusHUDView, NibLoadable {
1515

1616
@IBOutlet public weak var basalRateHUD: BasalRateHUDView!
1717

18-
@IBOutlet public weak var pumpManagerProvidedHUD: LevelHUDView!
18+
@IBOutlet public weak var pumpManagerProvidedHUD: BaseHUDView!
1919

2020
override public var orderPriority: HUDViewOrderPriority {
2121
return 3
@@ -84,7 +84,7 @@ public final class PumpStatusHUDView: DeviceStatusHUDView, NibLoadable {
8484
pumpManagerProvidedHUD.removeFromSuperview()
8585
}
8686

87-
public func addPumpManagerProvidedHUDView(_ pumpManagerProvidedHUD: LevelHUDView) {
87+
public func addPumpManagerProvidedHUDView(_ pumpManagerProvidedHUD: BaseHUDView) {
8888
self.pumpManagerProvidedHUD = pumpManagerProvidedHUD
8989
statusStackView.addArrangedSubview(self.pumpManagerProvidedHUD)
9090
}

LoopUI/Views/StatusBarHUDView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public class StatusBarHUDView: UIView, NibLoadable {
6666
pumpStatusHUD.removePumpManagerProvidedHUD()
6767
}
6868

69-
public func addPumpManagerProvidedHUDView(_ pumpManagerProvidedHUD: LevelHUDView) {
69+
public func addPumpManagerProvidedHUDView(_ pumpManagerProvidedHUD: BaseHUDView) {
7070
pumpStatusHUD.addPumpManagerProvidedHUDView(pumpManagerProvidedHUD)
7171
}
7272
}

0 commit comments

Comments
 (0)