Skip to content

Commit 4c5e32c

Browse files
Bharat Medirattaps2
Bharat Mediratta
authored and
ps2
committed
Remove default value for allowPredictiveTempBelowRange (#297)
* Copy InsulinKit framework for DoseMathTests (otherwise it won't run) * Remove default value for allowPredictiveTempBelowRange Make this explicit to remove confusion since the only place where we rely on the default value is in our unit tests.
1 parent 7f2d857 commit 4c5e32c

File tree

3 files changed

+35
-17
lines changed

3 files changed

+35
-17
lines changed

‎DoseMathTests/DoseMathTests.swift‎

Lines changed: 32 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@ class RecommendTempBasalTests: XCTestCase {
9797
maxBasalRate: maxBasalRate,
9898
glucoseTargetRange: glucoseTargetRange,
9999
insulinSensitivity: insulinSensitivitySchedule,
100-
basalRateSchedule: basalRateSchedule
100+
basalRateSchedule: basalRateSchedule,
101+
allowPredictiveTempBelowRange: false
101102
)
102103

103104
XCTAssertNil(dose)
@@ -112,7 +113,8 @@ class RecommendTempBasalTests: XCTestCase {
112113
maxBasalRate: maxBasalRate,
113114
glucoseTargetRange: glucoseTargetRange,
114115
insulinSensitivity: insulinSensitivitySchedule,
115-
basalRateSchedule: basalRateSchedule
116+
basalRateSchedule: basalRateSchedule,
117+
allowPredictiveTempBelowRange: false
116118
)
117119

118120
XCTAssertNil(dose)
@@ -132,7 +134,8 @@ class RecommendTempBasalTests: XCTestCase {
132134
maxBasalRate: maxBasalRate,
133135
glucoseTargetRange: glucoseTargetRange,
134136
insulinSensitivity: insulinSensitivitySchedule,
135-
basalRateSchedule: basalRateSchedule
137+
basalRateSchedule: basalRateSchedule,
138+
allowPredictiveTempBelowRange: false
136139
)
137140

138141
XCTAssertEqual(0, dose!.rate)
@@ -148,7 +151,8 @@ class RecommendTempBasalTests: XCTestCase {
148151
maxBasalRate: maxBasalRate,
149152
glucoseTargetRange: glucoseTargetRange,
150153
insulinSensitivity: insulinSensitivitySchedule,
151-
basalRateSchedule: basalRateSchedule
154+
basalRateSchedule: basalRateSchedule,
155+
allowPredictiveTempBelowRange: false
152156
)
153157

154158
XCTAssertEqual(0, dose!.rate)
@@ -197,7 +201,8 @@ class RecommendTempBasalTests: XCTestCase {
197201
maxBasalRate: maxBasalRate,
198202
glucoseTargetRange: glucoseTargetRange,
199203
insulinSensitivity: insulinSensitivitySchedule,
200-
basalRateSchedule: basalRateSchedule
204+
basalRateSchedule: basalRateSchedule,
205+
allowPredictiveTempBelowRange: false
201206
)
202207

203208
XCTAssertEqualWithAccuracy(0.125, dose!.rate, accuracy: 1.0 / 40.0)
@@ -218,7 +223,8 @@ class RecommendTempBasalTests: XCTestCase {
218223
maxBasalRate: maxBasalRate,
219224
glucoseTargetRange: glucoseTargetRange,
220225
insulinSensitivity: insulinSensitivitySchedule,
221-
basalRateSchedule: basalRateSchedule
226+
basalRateSchedule: basalRateSchedule,
227+
allowPredictiveTempBelowRange: false
222228
)
223229

224230
XCTAssertNil(dose)
@@ -238,7 +244,8 @@ class RecommendTempBasalTests: XCTestCase {
238244
maxBasalRate: maxBasalRate,
239245
glucoseTargetRange: glucoseTargetRange,
240246
insulinSensitivity: insulinSensitivitySchedule,
241-
basalRateSchedule: basalRateSchedule
247+
basalRateSchedule: basalRateSchedule,
248+
allowPredictiveTempBelowRange: false
242249
)
243250

244251
XCTAssertEqualWithAccuracy(0.125, dose!.rate, accuracy: 1.0 / 40.0)
@@ -259,7 +266,8 @@ class RecommendTempBasalTests: XCTestCase {
259266
maxBasalRate: maxBasalRate,
260267
glucoseTargetRange: glucoseTargetRange,
261268
insulinSensitivity: insulinSensitivitySchedule,
262-
basalRateSchedule: basalRateSchedule
269+
basalRateSchedule: basalRateSchedule,
270+
allowPredictiveTempBelowRange: false
263271
)
264272

265273
XCTAssertEqualWithAccuracy(0.125, dose!.rate, accuracy: 1.0 / 40.0)
@@ -309,7 +317,8 @@ class RecommendTempBasalTests: XCTestCase {
309317
maxBasalRate: maxBasalRate,
310318
glucoseTargetRange: glucoseTargetRange,
311319
insulinSensitivity: insulinSensitivitySchedule,
312-
basalRateSchedule: basalRateSchedule
320+
basalRateSchedule: basalRateSchedule,
321+
allowPredictiveTempBelowRange: false
313322
)
314323

315324
XCTAssertEqual(0, dose!.rate)
@@ -325,7 +334,8 @@ class RecommendTempBasalTests: XCTestCase {
325334
maxBasalRate: maxBasalRate,
326335
glucoseTargetRange: glucoseTargetRange,
327336
insulinSensitivity: insulinSensitivitySchedule,
328-
basalRateSchedule: basalRateSchedule
337+
basalRateSchedule: basalRateSchedule,
338+
allowPredictiveTempBelowRange: false
329339
)
330340

331341
XCTAssertEqual(0, dose!.rate)
@@ -375,7 +385,8 @@ class RecommendTempBasalTests: XCTestCase {
375385
maxBasalRate: maxBasalRate,
376386
glucoseTargetRange: glucoseTargetRange,
377387
insulinSensitivity: insulinSensitivitySchedule,
378-
basalRateSchedule: basalRateSchedule
388+
basalRateSchedule: basalRateSchedule,
389+
allowPredictiveTempBelowRange: false
379390
)
380391

381392
XCTAssertEqual(3.0, dose!.rate)
@@ -391,7 +402,8 @@ class RecommendTempBasalTests: XCTestCase {
391402
maxBasalRate: maxBasalRate,
392403
glucoseTargetRange: glucoseTargetRange,
393404
insulinSensitivity: insulinSensitivitySchedule,
394-
basalRateSchedule: basalRateSchedule
405+
basalRateSchedule: basalRateSchedule,
406+
allowPredictiveTempBelowRange: false
395407
)
396408

397409
XCTAssertEqualWithAccuracy(1.425, dose!.rate, accuracy: 1.0 / 40.0)
@@ -407,7 +419,8 @@ class RecommendTempBasalTests: XCTestCase {
407419
maxBasalRate: maxBasalRate,
408420
glucoseTargetRange: glucoseTargetRange,
409421
insulinSensitivity: insulinSensitivitySchedule,
410-
basalRateSchedule: basalRateSchedule
422+
basalRateSchedule: basalRateSchedule,
423+
allowPredictiveTempBelowRange: false
411424
)
412425

413426
XCTAssertEqualWithAccuracy(1.475, dose!.rate, accuracy: 1.0 / 40.0)
@@ -423,7 +436,8 @@ class RecommendTempBasalTests: XCTestCase {
423436
maxBasalRate: maxBasalRate,
424437
glucoseTargetRange: glucoseTargetRange,
425438
insulinSensitivity: self.insulinSensitivitySchedule,
426-
basalRateSchedule: basalRateSchedule
439+
basalRateSchedule: basalRateSchedule,
440+
allowPredictiveTempBelowRange: false
427441
)
428442

429443
XCTAssertEqual(3.0, dose!.rate)
@@ -438,7 +452,8 @@ class RecommendTempBasalTests: XCTestCase {
438452
maxBasalRate: maxBasalRate,
439453
glucoseTargetRange: glucoseTargetRange,
440454
insulinSensitivity: insulinSensitivitySchedule,
441-
basalRateSchedule: basalRateSchedule
455+
basalRateSchedule: basalRateSchedule,
456+
allowPredictiveTempBelowRange: false
442457
)
443458

444459
XCTAssertEqualWithAccuracy(2.975, dose!.rate, accuracy: 1.0 / 40.0)
@@ -451,7 +466,8 @@ class RecommendTempBasalTests: XCTestCase {
451466
maxBasalRate: maxBasalRate,
452467
glucoseTargetRange: glucoseTargetRange,
453468
insulinSensitivity: insulinSensitivitySchedule,
454-
basalRateSchedule: basalRateSchedule
469+
basalRateSchedule: basalRateSchedule,
470+
allowPredictiveTempBelowRange: false
455471
)
456472

457473
XCTAssertNil(dose)

‎Loop.xcodeproj/project.pbxproj‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@
151151
43FBEDD81D73843700B21F22 /* LevelMaskView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43FBEDD71D73843700B21F22 /* LevelMaskView.swift */; };
152152
4D3B40041D4A9E1A00BC6334 /* G4ShareSpy.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4D3B40021D4A9DFE00BC6334 /* G4ShareSpy.framework */; };
153153
4D5B7A4B1D457CCA00796CA9 /* GlucoseG4.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4D5B7A4A1D457CCA00796CA9 /* GlucoseG4.swift */; };
154+
4F526D5D1DF0FD6500A04910 /* InsulinKit.framework in CopyFiles */ = {isa = PBXBuildFile; fileRef = 43C6407B1DA051850093E25D /* InsulinKit.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
154155
C10428971D17BAD400DD539A /* NightscoutUploadKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = C10428961D17BAD400DD539A /* NightscoutUploadKit.framework */; };
155156
C15713821DAC6983005BC4D2 /* MealBolusNightscoutTreatment.swift in Sources */ = {isa = PBXBuildFile; fileRef = C15713811DAC6983005BC4D2 /* MealBolusNightscoutTreatment.swift */; };
156157
C17884631D51A7A400405663 /* BatteryIndicator.swift in Sources */ = {isa = PBXBuildFile; fileRef = C17884621D51A7A400405663 /* BatteryIndicator.swift */; };
@@ -234,6 +235,7 @@
234235
dstPath = "";
235236
dstSubfolderSpec = 10;
236237
files = (
238+
4F526D5D1DF0FD6500A04910 /* InsulinKit.framework in CopyFiles */,
237239
43E2D9171D2226BD004DA55F /* LoopKit.framework in CopyFiles */,
238240
);
239241
runOnlyForDeploymentPostprocessing = 0;

‎Loop/Managers/DoseMath.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ struct DoseMath {
6262
glucoseTargetRange: GlucoseRangeSchedule,
6363
insulinSensitivity: InsulinSensitivitySchedule,
6464
basalRateSchedule: BasalRateSchedule,
65-
allowPredictiveTempBelowRange: Bool = false
65+
allowPredictiveTempBelowRange: Bool
6666
) -> (rate: Double, duration: TimeInterval)? {
6767
guard glucose.count > 1 else {
6868
return nil

0 commit comments

Comments
 (0)