Skip to content

Conversation

@daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Oct 14, 2021

What does this PR do?

Deprecates GPUStatsMonitor and XLAStatsMonitor, as they can now be replaced by the DeviceStatsMonitor which calls get_device_stats on the Accelerator interface.

Part of #9032

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #9924 (73580a3) into master (940b910) will decrease coverage by 4%.
The diff coverage is 75%.

@@           Coverage Diff           @@
##           master   #9924    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15745   15780    +35     
=======================================
- Hits        14597   14010   -587     
- Misses       1148    1770   +622     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Great work !

@mergify mergify bot added the ready PRs ready to be merged label Oct 14, 2021
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
@carmocca carmocca added this to the v1.5 milestone Oct 14, 2021
@carmocca carmocca enabled auto-merge (squash) October 14, 2021 15:17
@carmocca carmocca added callback deprecation Includes a deprecation labels Oct 14, 2021
@carmocca carmocca merged commit 6feda08 into Lightning-AI:master Oct 14, 2021
@daniellepintz daniellepintz deleted the dep_mon branch October 14, 2021 17:02
rohitgr7 added a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
…StatsMonitor` (Lightning-AI#9924)

Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback deprecation Includes a deprecation ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants