Skip to content

scheduled removal of Trainer.running_sanity_check #9209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2021
Merged

scheduled removal of Trainer.running_sanity_check #9209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82ce2b7
scheduled removal of deprecated property
Tshimanga Aug 30, 2021
a523628
update CHANGELOG.md
Tshimanga Aug 30, 2021
91b72a5
update CHANGELOG.md entry to indicate as successor to
Tshimanga Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

- Removed deprecated `profiled_functions` argument from `PyTorchProfiler` ([#9178](https://github.com/PyTorchLightning/pytorch-lightning/pull/9178))


- Removed deprecated property `Trainer.running_sanity_check` in favor of `Trainer.sanity_checking` ([#9209](https://github.com/PyTorchLightning/pytorch-lightning/pull/9209))

### Fixed

- Fixed save/load/resume from checkpoint for DeepSpeed Plugin (
Expand Down
8 changes: 0 additions & 8 deletions pytorch_lightning/trainer/deprecated_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,8 @@

class DeprecatedTrainerAttributes:

sanity_checking: bool
fit_loop: FitLoop

@property
def running_sanity_check(self) -> bool:
rank_zero_deprecation(
"`Trainer.running_sanity_check` has been renamed to `Trainer.sanity_checking` and will be removed in v1.5."
)
return self.sanity_checking

@property
def train_loop(self) -> FitLoop:
rank_zero_deprecation(
Expand Down
6 changes: 0 additions & 6 deletions tests/deprecated_api/test_remove_1-5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@
from tests.helpers.utils import no_warning_call


def test_v1_5_0_running_sanity_check():
trainer = Trainer()
with pytest.deprecated_call(match="has been renamed to `Trainer.sanity_checking`"):
assert not trainer.running_sanity_check


def test_v1_5_0_model_checkpoint_period(tmpdir):
with no_warning_call(DeprecationWarning):
ModelCheckpoint(dirpath=tmpdir)
Expand Down