Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 12, 2021

What does this PR do?

Fixes #8833

Bug exists only on master after introducing state_id in #6886. Therefore the milestone is 1.5.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Aug 12, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #8869 (6e59195) into master (24f0124) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8869   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         169     169           
  Lines       14078   14078           
======================================
- Hits        13052   13045    -7     
- Misses       1026    1033    +7     

@awaelchli awaelchli closed this Aug 26, 2021
@awaelchli
Copy link
Contributor Author

covered by #7161

@awaelchli awaelchli deleted the bugfix/callback-resume-warn branch August 26, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working callback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary warning when resuming training

1 participant