Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 7, 2021

What does this PR do?

Usual business. Dependency releases new update and our CI goes down.
Gotta tweak some numbers to keep the machine running and heads attached.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Jun 7, 2021
@awaelchli awaelchli added this to the v1.3.x milestone Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #7869 (720f948) into master (20f37b8) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7869   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         202     202           
  Lines       13123   13123           
======================================
- Hits        12156   12118   -38     
- Misses        967    1005   +38     

@awaelchli awaelchli marked this pull request as ready for review June 7, 2021 21:51
@awaelchli awaelchli added the priority: 0 High priority task label Jun 7, 2021
@awaelchli awaelchli enabled auto-merge (squash) June 7, 2021 22:06
@kaushikb11
Copy link
Contributor

Did we create an issue on fsspec end?

@awaelchli awaelchli merged commit ce97676 into master Jun 7, 2021
@awaelchli awaelchli deleted the ci/fsspec-update branch June 7, 2021 23:35
@SeanNaren SeanNaren mentioned this pull request Jun 8, 2021
SeanNaren pushed a commit that referenced this pull request Jun 8, 2021
(cherry picked from commit ce97676)
lexierule pushed a commit that referenced this pull request Jun 9, 2021
(cherry picked from commit ce97676)
@f4hy
Copy link
Contributor

f4hy commented Jun 22, 2021

@awaelchli this requires all users of lighting to also get the latest version of fsspec. is there a feature we are using that is incompatible with older builds of fsspec?

@awaelchli
Copy link
Contributor Author

awaelchli commented Jun 22, 2021

it affects all lightning users? why?

If I remember correctly it had to do with tmpdir in pytest fixture not being a string and fsspec from one version to another had problems with that. A possible solution is #7876 maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 0 High priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants