-
Notifications
You must be signed in to change notification settings - Fork 3.6k
update fsspec to 2021.06.0 #7869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7869 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 202 202
Lines 13123 13123
======================================
- Hits 12156 12118 -38
- Misses 967 1005 +38 |
|
Did we create an issue on |
(cherry picked from commit ce97676)
(cherry picked from commit ce97676)
|
@awaelchli this requires all users of lighting to also get the latest version of fsspec. is there a feature we are using that is incompatible with older builds of fsspec? |
|
it affects all lightning users? why? If I remember correctly it had to do with tmpdir in pytest fixture not being a string and fsspec from one version to another had problems with that. A possible solution is #7876 maybe? |
What does this PR do?
Usual business. Dependency releases new update and our CI goes down.
Gotta tweak some numbers to keep the machine running and heads attached.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃