Skip to content

[bugfix] Resolve LearningRateMonitor + BackboneFinetuning #7835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 7, 2021
Merged

[bugfix] Resolve LearningRateMonitor + BackboneFinetuning #7835

merged 11 commits into from
Jun 7, 2021

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 4, 2021 •
edited
Loading

What does this PR do?

Fixes #7830

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the bug Something isn't working label Jun 4, 2021
@tchaton tchaton added this to the v1.3.x milestone Jun 4, 2021
@tchaton tchaton self-assigned this Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

Merging #7835 (472ba3b) into master (ca89a7f) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7835    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         199     202     +3     
  Lines       13017   13073    +56     
=======================================
- Hits        12052   11480   -572     
- Misses        965    1593   +628

awaelchli
awaelchli approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just minor comments

ethanwharris
ethanwharris approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment

Borda
Borda reviewed Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ready? I see some remaining debugging prints etc.

@tchaton tchaton enabled auto-merge (squash) June 4, 2021 21:17
carmocca
carmocca suggested changes Jun 6, 2021
View reviewed changes
@carmocca carmocca disabled auto-merge June 7, 2021 09:39
carmocca
carmocca approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@tchaton tchaton enabled auto-merge (squash) June 7, 2021 09:55
@tchaton tchaton merged commit d1becce into master Jun 7, 2021
@tchaton tchaton deleted the bug_learning_rate_finetuning branch June 7, 2021 10:17
@SeanNaren SeanNaren mentioned this pull request Jun 8, 2021
Closed
SeanNaren pushed a commit that referenced this pull request Jun 8, 2021
@tchaton @Borda @carmocca
[bugfix] Resolve LearningRateMonitor + BackboneFinetuning (#7835)
0c12e88 
* add test + resolve bug

* update changelog

* resolve bug

* resolve bug

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <[email protected]>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <[email protected]>

* update on comments

* resolve comments

* update

* Update tests/callbacks/test_lr_monitor.py

Co-authored-by: Carlos Mocholí <[email protected]>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Carlos Mocholí <[email protected]>

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit d1becce)
Borda added a commit that referenced this pull request Jun 8, 2021
@tchaton @Borda @carmocca
[bugfix] Resolve LearningRateMonitor + BackboneFinetuning (#7835)
9feb570 
* add test + resolve bug

* update changelog

* resolve bug

* resolve bug

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <[email protected]>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <[email protected]>

* update on comments

* resolve comments

* update

* Update tests/callbacks/test_lr_monitor.py

Co-authored-by: Carlos Mocholí <[email protected]>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Carlos Mocholí <[email protected]>

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Jun 9, 2021
@tchaton @Borda
@carmocca @lexierule
[bugfix] Resolve LearningRateMonitor + BackboneFinetuning (#7835)
6c7ae16 
* add test + resolve bug

* update changelog

* resolve bug

* resolve bug

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <[email protected]>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <[email protected]>

* update on comments

* resolve comments

* update

* Update tests/callbacks/test_lr_monitor.py

Co-authored-by: Carlos Mocholí <[email protected]>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Carlos Mocholí <[email protected]>

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit d1becce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda left review comments

@ethanwharris ethanwharris ethanwharris approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tchaton tchaton

Labels

bug Something isn't working

Projects

None yet

Milestone

pl:1.3.x

Development

Successfully merging this pull request may close these issues.

Error with BackboneFinetuning and LearningRateMonitor with logging_interval="epoch"

5 participants

@tchaton @awaelchli @Borda @ethanwharris @carmocca