From be149ce9f3fefd30cc34dfb8ad9b3f9baf92a2ef Mon Sep 17 00:00:00 2001 From: Jirka Date: Mon, 31 May 2021 17:39:28 +0200 Subject: [PATCH 1/3] update precommit --- .pre-commit-config.yaml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 5814ea965d179..f66c8ed496f17 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -19,17 +19,26 @@ repos: - repo: https://github.com/pre-commit/pre-commit-hooks rev: v4.0.1 hooks: - - id: trailing-whitespace - id: end-of-file-fixer + - id: trailing-whitespace + - id: check-yaml + - id: pretty-format-json - repo: https://github.com/PyCQA/isort rev: 5.8.0 hooks: - id: isort - args: [--settings-path, ./pyproject.toml] + name: imports - repo: https://github.com/pre-commit/mirrors-yapf rev: v0.31.0 hooks: - id: yapf - args: [--parallel, --in-place] + name: formatting + language: python + + - repo: https://github.com/PyCQA/flake8 + rev: 3.9.2 + hooks: + - id: flake8 + name: PEP8 From 96932ae4d99707bc5869bcdfd84292aac3532970 Mon Sep 17 00:00:00 2001 From: Jirka Borovec Date: Mon, 31 May 2021 19:19:04 +0200 Subject: [PATCH 2/3] Update .pre-commit-config.yaml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Carlos Mocholí --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f66c8ed496f17..3a6abe40ae59b 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -22,7 +22,7 @@ repos: - id: end-of-file-fixer - id: trailing-whitespace - id: check-yaml - - id: pretty-format-json + #- id: pretty-format-json - repo: https://github.com/PyCQA/isort rev: 5.8.0 From 01ee92c5853a42ea208ba2ab4c56e60d0ecfa20d Mon Sep 17 00:00:00 2001 From: Jirka Borovec Date: Mon, 31 May 2021 23:24:25 +0200 Subject: [PATCH 3/3] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Carlos Mocholí --- .pre-commit-config.yaml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 3a6abe40ae59b..b7dcc232e66d6 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -22,23 +22,25 @@ repos: - id: end-of-file-fixer - id: trailing-whitespace - id: check-yaml - #- id: pretty-format-json + - id: check-docstring-first + - id: check-executables-have-shebangs + - id: check-toml - repo: https://github.com/PyCQA/isort rev: 5.8.0 hooks: - id: isort - name: imports + name: Format imports - repo: https://github.com/pre-commit/mirrors-yapf rev: v0.31.0 hooks: - id: yapf - name: formatting + name: Format code language: python - repo: https://github.com/PyCQA/flake8 rev: 3.9.2 hooks: - id: flake8 - name: PEP8 + name: Check PEP8