Skip to content

Conversation

@justusschock
Copy link
Member

@justusschock justusschock commented May 27, 2021

What does this PR do?

Add Test to ensure Training Batch is no longer in GPU memory when running validation

Follow up test of #7357

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #7733 (fe96e55) into master (04dcb17) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7733   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         199     199           
  Lines       12962   12998   +36     
======================================
+ Hits        11967   11994   +27     
- Misses        995    1004    +9     

@justusschock justusschock marked this pull request as ready for review May 27, 2021 15:13
@awaelchli awaelchli added the ci Continuous Integration label May 27, 2021
@awaelchli awaelchli added this to the v1.4 milestone May 27, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test

@justusschock justusschock enabled auto-merge (squash) May 28, 2021 14:07
@justusschock justusschock merged commit 5fc6f06 into master May 28, 2021
@justusschock justusschock deleted the test/validation_memory_consumption branch May 28, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants