Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented May 19, 2021

What does this PR do?

it shall speed up the docker building

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the feature Is an improvement or enhancement label May 19, 2021
@Borda Borda requested review from carmocca and tchaton as code owners May 19, 2021 07:49
@Borda Borda requested a review from a team May 19, 2021 07:49
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #7606 (b6bc0b6) into master (20f6337) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7606    +/-   ##
=======================================
- Coverage      92%     88%    -5%     
=======================================
  Files         197     197            
  Lines       12878   12878            
=======================================
- Hits        11899   11312   -587     
- Misses        979    1566   +587     

Co-authored-by: Roger Shieh <[email protected]>
@Borda Borda enabled auto-merge (squash) May 19, 2021 08:42
@Borda Borda added the ready PRs ready to be merged label May 19, 2021
@mergify mergify bot requested a review from a team May 19, 2021 08:43
@Borda Borda merged commit 6e56f56 into master May 19, 2021
@Borda Borda deleted the docker/nproc branch May 19, 2021 19:48
@carmocca carmocca added this to the v1.4 milestone May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Is an improvement or enhancement ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants